Should we mass replace usages of CLASS with self::class?
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Fomafix
	Mar 27 2023, 11:27 AM

Project Tags

Referenced Files

None

Subscribers

Description

A static function MyClass::myFunction

class MyClass {
	private static myFunction() {
	}
}

can be referenced as callable in the same by class as

[ self::class, 'myFunction' ]
self::class . '::myFunction'
[ __CLASS__, 'myFunction' ]
__CLASS__ . '::myFunction'
[ 'MyClass', 'myFunction' ]
'MyClass::myFunction'

It's unclear if there is a preferred variant and which one it should be.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Use self::class to reference a static function in the same class	mediawiki/core	master	+57 -57
Use self::class to reference a static function in the same class	mediawiki/extensions/FlaggedRevs	master	+1 -1
Use self::class reference a static function in the same class	mediawiki/extensions/Gadgets	master	+2 -2
Use self::class reference a static function in the same class	mediawiki/extensions/Video	master	+4 -4
Use self::class instead of __CLASS__ to reference the self class	mediawiki/extensions/JsonData	master	+1 -1

Customize query in gerrit

Event Timeline

Fomafix created this task.Mar 27 2023, 11:27 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 27 2023, 11:27 AM

Change 900813 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/core@master] Use self::class instead of __CLASS__ to resolve self class name

https://gerrit.wikimedia.org/r/900813

gerritbot added a project: Patch-For-Review.Mar 27 2023, 11:28 AM

Aklapper added a project: MediaWiki-General.Mar 27 2023, 11:46 AM

thiemowmde renamed this task from Use self::class to reference a function in the self class as callable to Should we mass replace usages of __CLASS__ with self::class?.Mar 28 2023, 3:50 PM

thiemowmde removed Fomafix as the assignee of this task.

thiemowmde edited projects, added: MediaWiki-Codesniffer; removed: MediaWiki-General.

thiemowmde updated the task description. (Show Details)

thiemowmde added subscribers: Krinkle, Umherirrender.

Fomafix updated the task description. (Show Details)Mar 29 2023, 9:56 AM

Umherirrender unsubscribed.Jul 12 2023, 7:57 PM

Change #900823 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/extensions/JsonData@master] Use self::class instead of __CLASS__ to reference the self class

https://gerrit.wikimedia.org/r/900823

Change #900823 merged by jenkins-bot:

[mediawiki/extensions/JsonData@master] Use self::class instead of __CLASS__ to reference the self class

https://gerrit.wikimedia.org/r/900823

Change #1081918 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/extensions/Video@master] Use self::class reference a static function in the same class

https://gerrit.wikimedia.org/r/1081918

Change #900820 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/extensions/Gadgets@master] Use self::class instead of __CLASS__ to resolve self class name

https://gerrit.wikimedia.org/r/900820

Change #1081918 merged by jenkins-bot:

[mediawiki/extensions/Video@master] Use self::class reference a static function in the same class

https://gerrit.wikimedia.org/r/1081918

Change #900820 merged by jenkins-bot:

[mediawiki/extensions/Gadgets@master] Use self::class reference a static function in the same class

https://gerrit.wikimedia.org/r/900820

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.21; 2025-03-18).Mar 14 2025, 6:00 PM

Change #900827 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/extensions/FlaggedRevs@master] Use self::class to reference a static function in the same class

https://gerrit.wikimedia.org/r/900827

Novem_Linguae subscribed.May 19 2025, 6:59 AM

Change #900827 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Use self::class to reference a static function in the same class

https://gerrit.wikimedia.org/r/900827

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 19 2025, 6:00 PM

Change #900813 merged by jenkins-bot:

[mediawiki/core@master] Use self::class to reference a static function in the same class

https://gerrit.wikimedia.org/r/900813

ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.4; 2025-06-03); removed: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 29 2025, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 29 2025, 9:30 PM

Should we mass replace usages of __CLASS__ with self::class?Open, Needs TriagePublicActions

Description

Details

Event Timeline

Should we mass replace usages of CLASS with self::class?
Open, Needs TriagePublic
Actions