Page MenuHomePhabricator

On narrow screens "External maps" footer button vanishes
Closed, ResolvedPublic

Description

On narrow screens the buttons in the footer move underneath each other. Depending on the widht/label text on the buttons this can be very common. With German text it's around 440px and would be a common issue for mobile phones that are not used in landscape mode.

Currently there's no way to make the 2nd button visible.

Narrow Screen.png (783×655 px, 263 KB)

Requirements

  • Implement flexible height for footer, max height being 30% of screen. If content exceeds 30%, a scrollbar is added.
  • See figma file for specifications

Event Timeline

Change 903252 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Kartographer@master] Nearby: y-scroll footer if screens are narrow

https://gerrit.wikimedia.org/r/903252

WIP patch can be demoed in story time.

Change 904093 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Nearby: Let footer buttons wrap on very narrow screens

https://gerrit.wikimedia.org/r/904093

Change 904162 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Use LESS variables in fullscreen map CSS

https://gerrit.wikimedia.org/r/904162

Change 906007 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Kartographer@master] [PoC] Grid footer with flexible height

https://gerrit.wikimedia.org/r/906007

Change 903252 abandoned by WMDE-Fisch:

[mediawiki/extensions/Kartographer@master] Nearby: y-scroll footer if screens are narrow

Reason:

We will not go with the scrollbar approach.

https://gerrit.wikimedia.org/r/903252

Change 906052 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Kartographer@master] [WIP] Allow map footer elements to float when screens are narrow

https://gerrit.wikimedia.org/r/906052

Change 904162 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Use LESS variables in fullscreen map CSS

https://gerrit.wikimedia.org/r/904162

The patches ready for review improve the situation by allowing the footer to expand and text and buttons to float. Another easy win for mobile/narrow screens could be slightly tweaking the font size. The MediaViewer has a system that - on desktop - lets the font size vary depending on the used space between 20px, 16px and 14px. On mobile this is always fixed to a default of 16px.

The maps are pretty plain in that regard. The font size in the footer is always 20px. I find that quite huge. See screenshots below.

Mobile Map.png (762×362 px, 204 KB)

Mobile Image.png (762×362 px, 455 KB)

Side-note: The size of the button texts is also different. For maps it's set to 14px in the MediaViewer it's a default of 16px.

Change 906007 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Convert map footer to grid layout

https://gerrit.wikimedia.org/r/906007

Change 906052 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Allow map footer elements to float when screens are narrow

https://gerrit.wikimedia.org/r/906052

Change 904093 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/Kartographer@master] Nearby: Let footer buttons wrap on very narrow screens

Reason:

https://gerrit.wikimedia.org/r/904093

WMDE-Fisch removed WMDE-Fisch as the assignee of this task.

Change 914738 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Convert fullscreen map footer from grid to flex layout

https://gerrit.wikimedia.org/r/914738

Change 914738 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Convert fullscreen map footer from grid to flex layout

https://gerrit.wikimedia.org/r/914738