Sorry about that.

I think the simplest fix is to conditionally include the stubs like so: https://github.com/wikimedia/mediawiki/blob/master/.phan/config.php#L30

Okay, that would work. And now I think I understand why Cargo has these class re-declarations: so that the validation will know that these classes exist, since Admin Links is not being loaded. But why do none of the other extensions that also hook in to Admin Links (https://www.mediawiki.org/wiki/Category:AdminLinks_extensions) need these class declarations? (I think.)

In T333181#8730071, @Yaron_Koren wrote:

Okay, that would work. And now I think I understand why Cargo has these class re-declarations: so that the validation will know that these classes exist, since Admin Links is not being loaded. But why do none of the other extensions that also hook in to Admin Links (https://www.mediawiki.org/wiki/Category:AdminLinks_extensions) need these class declarations? (I think.)

I haven't checked all of them, but the stubs would only be needed if Phan is configured for these extensions - otherwise WMF CI won't try to run Phan and it won't complain about missing classes.

Okay, that makes sense.

It looks like the dependencies for Phan have to be added to integration/config, as well as Cargo's own Phan config. Documentation here: https://www.mediawiki.org/wiki/Continuous_integration/Tutorials/Add_phan_to_a_MediaWiki_extension#Advanced

So, should I revert the Cargo change? It sounds extreme, but I need to be able to check in changes to Page Forms - and any other extension that is affected by this.

That should be fine for now. After that, we could either:

• Configure PageForms to ignore Phan stubs in other extensions via a config stanza such as $cfg['exclude_file_regex'] = '@^../../extensions/Cargo/.phan/stubs/@';, or
• Reimplement the hooks change in Cargo without stubs. This will require people to have a checkout of the AdminLinks extension to run phan locally and will also need a corresponding integration/config patch as noted by Sam.

Both are viable options.

@TK-999 - okay, thanks for your understanding. I reverted the change, and re-added your PageSaveComplete fix. I don't think the first of those suggested fixes makes sense - if only because there's a reasonable chance that such a fix would also be needed for some of the other 20 or so extensions that make use of Admin Links. So I guess that just leaves the second fix.