Page MenuHomePhabricator

Monitor the number of revisions requested via temporary account revision API
Closed, DeclinedPublic

Description

See discussion on T327946.

The CheckUser API for viewing IP addresses used by a temporary account for editing certain revisions is structured:

/checkuser/v0/temporaryaccount/{name}/revisions/{ids}

...where multiple revision IDs may be passed. The default limit for those with the right apihighlimits is 500, and for those without is 50.

500 revision IDs could lead to a long URL (longer than Edge/IE's c.2000 maximum if revision IDs are longer than a few digits). But for this to happen via the UI, a single temporary user account would need to have 500 revision IDs on a single page.

We'd like to know...

  • The rough distribution of the number of revision IDs requested via this API

...so we can decide:

  • Should we do anything special to ensure the maximum URL length is never exceeded, or is this likely a very minor edge case?
  • Should we do anything to increase the limits, e.g. because they are being hit a lot?

Event Timeline

Without knowing how this is being used, I'm not sure if we should preoptimize. Let's add a log line and deal with it when it trips?

Since this task was filed, we have received feedback via another task: T385546: When too many revisions are revealed at once using the IP reveal APIs, the request fails because the URL is too long.

I'll close this, since we seem to already know that this is worth fixing, without the additional monitoring.