Special:MyLanguage: Base page language being ignored / skipped from the language fallback chain
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Winston_Sung
	Mar 27 2023, 3:52 PM

Description

Special:MyLanguage: Base page language being ignored / skipped from the language fallback chain.

Steps to replicate the issue (include links if applicable):

Base page language: zh
User interface language: MediaWiki internal: zh-hk; BCP 47: zh-Hant-HK
Subpages for base page: zh (source, bot-auto-created), en (translated)

What happens?:

Special:MyLanguage redirected to /en

What should have happened instead?:

Special:MyLanguage redirected to base page (zh)

Software version (skip for WMF-hosted wikis like Wikipedia):

Reported from MediaWiki 1.39.2 ( eea3e36 ), from LuciferianThomas via Telegram
Reproduced on MediaWiki 1.40

Other information (browser name/version, screenshots, etc.):

Details

	Subject	Repo	Branch	Lines +/-
	SpecialMyLanguage: Cleanup and add more comments	mediawiki/core	master	+8 -4
	SpecialMyLanguage: Fix base page being ignored from language fallback detection	mediawiki/core	master	+10 -6

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
In Progress		Winston_Sung	T286291 Clean up, merge and update zh/zh-* translations
In Progress		Winston_Sung	T296188 Clean up, merge, update zh/zh-* translations and update zh-related language fallback chains in mediawiki/core
Open		None	T106131 MediaWiki.org should redirect user to appropriate Chinese variant and show them based on preferences
Resolved		Nikerabbit	T50292 Add support for fallbacks on Special:MyLanguage
Resolved		Winston_Sung	T278639 Add language redirects or backwards fallbacks for Special:MyLanguage
Resolved	BUG REPORT	Winston_Sung	T333187 Special:MyLanguage: Base page language being ignored / skipped from the language fallback chain

Event Timeline

Winston_Sung created this task.Mar 27 2023, 3:52 PM

Change 876409 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/core@master] SpecialMyLanguage: Fix base page being ignored from language fallback detection

https://gerrit.wikimedia.org/r/876409

gerritbot added a project: Patch-For-Review.Mar 27 2023, 3:52 PM

Winston_Sung moved this task from Untriaged to Fallback on the I18n board.Mar 27 2023, 4:00 PM

Winston_Sung changed the task status from Open to In Progress.Apr 11 2023, 3:58 AM

Winston_Sung claimed this task.

Nikerabbit removed a project: Language-Team.Apr 24 2023, 11:23 AM

Change 876409 merged by jenkins-bot:

[mediawiki/core@master] SpecialMyLanguage: Fix base page being ignored from language fallback detection

https://gerrit.wikimedia.org/r/876409

Maintenance_bot removed a project: Patch-For-Review.May 1 2023, 3:30 AM

Change 900723 had a related patch set uploaded (by Winston Sung; author: Winston Sung):

[mediawiki/core@master] SpecialMyLanguage: Update language page fallback functionality

https://gerrit.wikimedia.org/r/900723

gerritbot added a project: Patch-For-Review.May 1 2023, 6:38 AM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 3:01 AM

@Winston_Sung is there an example URL you can share that helps me understand this error? ie. URL redirects to wrong language?

In T333187#8932640, @Jdlrobson wrote:

@Winston_Sung is there an example URL you can share that helps me understand this error? ie. URL redirects to wrong language?

The bug is already resolved by the first patch, so nothing can be tested. This follow-up makes no change to the result, just some cleanups and comments:
The elseif ( $lang === $baseLang->getCode() ) is redundant, some IDE e.g. PhpStorm would already warn it; and $fragment is come from $base, so we can return early.

Maybe the patch should be renamed. and I agree that the commit message is too poor and didn't tell any of these.

Change 900723 merged by jenkins-bot:

[mediawiki/core@master] SpecialMyLanguage: Cleanup and add more comments

https://gerrit.wikimedia.org/r/900723

Winston_Sung closed this task as Resolved.Jun 20 2023, 4:13 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 20 2023, 4:33 PM

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.15; 2023-06-27); removed MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).Jun 20 2023, 5:00 PM