Page MenuHomePhabricator

"Add a link" dialog tab navigation
Closed, ResolvedPublic

Description

The tab key should navigate to the different input elements in the dialog but it closes the dialog.

Event Timeline

VYanez-WMF renamed this task from Addlink dialog tab navigation to "Add a link" dialog tab navigation.Mar 28 2023, 12:38 PM
VYanez-WMF created this task.

I belive this was resolved within T333348 since the tab navigation behaves just as the Codex dialog tab navigation behaves. Moving this to QA so others can test and assert the tab navigation is fine. For comparing behaviors, here's the Codex dialog demo with custom slots (intentionally pinned on v0.8.0 which introduced the new slots) and the Growth team implementation in the Add link dialog prototype.

Sgs changed the task status from Open to In Progress.Apr 12 2023, 10:34 AM
Sgs assigned this task to VYanez-WMF.
Sgs moved this task from Inbox to Triaged on the Growth-Team board.
Sgs changed the task status from In Progress to Open.Apr 12 2023, 10:45 AM
Sgs moved this task from Incoming to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
Etonkovidova closed this task as Resolved.EditedApr 14 2023, 5:14 PM
Etonkovidova subscribed.

I belive this was resolved within T333348 since the tab navigation behaves just as the Codex dialog tab navigation behaves. Moving this to QA so others can test and assert the tab navigation is fine. For comparing behaviors, here's the Codex dialog demo with custom slots (intentionally pinned on v0.8.0 which introduced the new slots) and the Growth team implementation in the Add link dialog prototype.

Thanks, @Sgs! The tab navigation is present in wmf.4 (the tab navigation orders is shown via Accessibility devTools on Firefox):

Screen Shot 2023-04-14 at 10.10.29 AM.png (902×1 px, 214 KB)
.