Page MenuHomePhabricator

Add documentation for "Add a link" on-boarding dialog
Open, Stalled, LowPublic

Description

Apparently there is no standard way of documenting Vue component properties, but the most accepted way seems to be to use JSDoc, with some decent tooling for building doc pages or reusing it in storybooks. PHPStorm doesn't support it yet but they support an intermediary format and a tool to auto-generate it from JSDoc.

We can start documenting this component using JSDoc and start exploring the tooling mentioned above.

Event Timeline

Sgs updated the task description. (Show Details)

Change 906544 had a related patch set uploaded (by Viviana Yanez; author: Viviana Yanez):

[mediawiki/extensions/GrowthExperiments@master] WIP documentation/frontend: document AddlinkDialog using JSDoc

https://gerrit.wikimedia.org/r/906544

Change 909995 had a related patch set uploaded (by Viviana Yanez; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Frontend documentation: add OnboardingDialog component documentation

https://gerrit.wikimedia.org/r/909995

Change 909995 abandoned by Viviana Yanez:

[mediawiki/extensions/GrowthExperiments@master] Frontend documentation: add OnboardingDialog component documentation

Reason:

https://gerrit.wikimedia.org/r/909995

Sgs changed the task status from Open to In Progress.Apr 24 2023, 10:53 AM
Sgs moved this task from Triaged to Sprint 0 (Growth Team) on the Growth-Team board.
Sgs edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
Sgs moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 906544 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Frontend documentation: add content to OnboardingDialog component demo page

https://gerrit.wikimedia.org/r/906544

The current documentation is written by hand. Ideally we would like to have an automated process for creating such docs based on the JSDoc annotations. We should work on a proper setup for this eventually, maybe reusing some of the setup for the codex library/docs.

Sgs changed the task status from In Progress to Stalled.May 16 2023, 10:46 AM
KStoller-WMF added a subscriber: KStoller-WMF.

I'm cleaning up some older tasks... should this remain in our current sprint?