Page MenuHomePhabricator

Features should fail sensibly when RESTBase is not yet set up
Open, Stalled, Needs TriagePublic

Description

When a new wiki is created, it takes some time before RESTBase is set up for it. A lot of things depend on RESTBase, and don't work without it. For all the things listed below, it seems like RESTBase is a hard dependency (at least in Wikimedia's setup), but the features still initially give the *appearance* of working, even though they don't.

All the screenshots are from https://anp.wikipedia.org/ with the interface language set to English. It was set up in T332115 six days ago; six days may not seem like much, but it is a long time to live with these errors for a community that has finally gotten its brand new wiki. For anpwiki's case, this will all be solved when T332380 is solved, but this keeps happening for every new wiki. Some times RESTBase is set up quite quickly after wiki creation, but some times it can take several days (like now).

Features with problems

Visual editor

Without RESTBase, you can start editing a new page with Visual Editor. However, when you try to save that page, it gives an error:

Screenshot_20230328_162425.png (605×994 px, 44 KB)

Likewise, you get an error when you try to edit an existing page, but then at least the error appears when you *start* editing:

Screenshot_20230328_162552.png (700×986 px, 91 KB)

Visual diffs

Visual diffs just show nothing. Here's a comparison between a visual diff and the same diff in wikitext:

Screenshot_20230328_164659.png (148×1 px, 17 KB)
Screenshot_20230328_164725.png (363×1 px, 35 KB)

Discussion tools

For the discussion tools, you can't actually post replies. It lets you start *writing* a reply, but you can't save it. It is also impossible to switch from source mode to visual mode.

Reply:

Screenshot_20230328_163249.png (322×941 px, 23 KB)

Curiously, you can create new topics, but only if you use the source editor. If you use the visual editor, you get the same error as above (as expected, really):

Screenshot_20230328_163443.png (448×987 px, 28 KB)

Content Translation

When you save a translation with the Content Translation tool, all of your text is lost and instead it saves some JSON as wikitext (!). More details about that in T333238.

Proposed solution

Because RESTBase is seemingly a hard dependency for these features, the features themselves should be temporarily disabled as long as RESTBase is not set up for a wiki. The current state, where contributors can start edits but aren't able to save them is potentially harmful since it wastes contributors' time and efforts.

Event Timeline

You may be interested in the RESTbase Sunsetting tag, which is about removing RESTbase in general.

@DLynch Oh, that sounds promising, I was not aware of that. Do you know what the timeline for that looks like?

I'm not sure what the goal is, sorry -- I know it's currently being worked on, though, rather than just being planned future work.

jhsoby changed the task status from Open to Stalled.Mar 29 2023, 11:21 AM

Alright, no problem. Good to know it's being actively worked on.
I'll mark this as stalled, hoping that the issues I've explained will be solved in other ways by that ongoing work in a reasonable-ish timeframe. Feel free to close as rejected/invalid instead if you think that makes more sense.

All of these editing tools no longer rely on RESTBase, and should now work in this scenario. Someone should test it all on another new wiki to confirm.