Page MenuHomePhabricator

Double title on Special:ReadingLists main page
Closed, ResolvedPublic

Description

Steps to reproduce

  1. Open https://meta.wikimedia.org/wiki/Special:ReadingLists.

What happens

  1. The page has two titles: “Reading lists” produced by PHP code and “Your lists” produced by Vue code.

Screenshot 2023-03-28 at 18-24-42 Reading lists - Meta.png (755×280 px, 37 KB)

What I’d expect

  1. There is only one title, using the formatting produced by PHP code.

Notes

  • The double title makes sense when an individual list is opened, but IMHO it doesn’t when the list of lists is visible.
  • The “Share list” button shouldn’t be there either, but that’s already tracked in T333236.
  • The font difference (bolder, no bottom border) looks strange to me. When shown on individual reading lists, it could also be smaller (currently both headings are exactly 1.8rem), as the reading list titles are subheadings to the entirety of reading lists.

Event Timeline

Jdlrobson claimed this task.
Jdlrobson subscribed.

This was since converted to a tab.

Screenshot 2024-04-19 at 11.56.05 AM.png (3,046×796 px, 120 KB)

I think it just got even more confusing:

  • There is an <h1>, which hasn’t changed, it says Reading lists.
  • There’s a namespace tab saying Your lists on Vector 2022, which became default on Meta in the meantime in T349544 (I don’t know if it was there on Vector 2022 when I opened this task). Couldn’t that be hidden, just like on many other special pages like preferences or contributions?
  • And there’s that changed thing, which now looks like a tab, but functions like a breadcrumb. If it functions like a breadcrumb, why doesn’t it look like one?

There’s a namespace tab saying Your lists on Vector 2022, which became default on Meta in the meantime in T349544 (I don’t know if it was there on Vector 2022 when I opened this task). Couldn’t that be hidden, just like on many other special pages like preferences or contributions?

Yeh I think the additional tab should be removed. Opened: T363418

And there’s that changed thing, which now looks like a tab, but functions like a breadcrumb. If it functions like a breadcrumb, why doesn’t it look like one?

Which one are you referring to? The second is the Codex tab component:

Screenshot 2024-04-24 at 2.19.04 PM.png (975×812 px, 176 KB)

There’s a namespace tab saying Your lists on Vector 2022, which became default on Meta in the meantime in T349544 (I don’t know if it was there on Vector 2022 when I opened this task). Couldn’t that be hidden, just like on many other special pages like preferences or contributions?

Yeh I think the additional tab should be removed. Opened: T363418

Thanks!

And there’s that changed thing, which now looks like a tab, but functions like a breadcrumb. If it functions like a breadcrumb, why doesn’t it look like one?

Which one are you referring to? The second is the Codex tab component:

Screenshot 2024-04-24 at 2.19.04 PM.png (975×812 px, 176 KB)

Yes, I’m referring to that.

  • It looks like a tab exactly because it uses the Codex tab component.
  • However, it functions like breadcrumbs:
    • When I open the page, it contains only the home (Your lists) tab (“I’m at the edge of the forest” using the Hansel and Gretel metaphor).
    • When I click on a list, both the home tab and the list appear (“I’ve arrived at the witch”).
    • When I go back to the home and select another list, the previously selected list disappears from the tabset (“I’ve arrived at another witch, the previous one isn’t interesting anymore”).