[mobile-wmf.1] Scrolling empty Watchlist - TypeError: Cannot read properties of undefined (reading 'top')
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Etonkovidova
	Mar 29 2023, 2:02 AM

Project Tags

Referenced Files

	F41520802: screenshot 268.png
	Nov 19 2023, 9:20 PM

	F41520801: screenshot 267.png
	Nov 19 2023, 9:20 PM

	F41514000: Screenshot 2023-11-17 at 7.58.12 AM.png
	Nov 17 2023, 3:58 PM

	F41511429: Screenshot 2023-11-16 at 12.01.20 PM.png
	Nov 16 2023, 6:01 PM

	F41499611: screenshot 203.png
	Nov 12 2023, 11:30 PM

	F41499610: screenshot 202.png
	Nov 12 2023, 11:30 PM

	F36931518: Screen Shot 2023-03-28 at 6.47.03 PM.png
	Mar 29 2023, 2:02 AM

Subscribers

Description

Note: the Console error is the same as T296863: TypeError: Cannot read properties of undefined (reading 'top')

Steps to reproduce:

On mobile as a user without articles on Watchlist, log in and go to the Watchlist.
Scroll the empty Watchlist - the Console will display the following error:

Screen Shot 2023-03-28 at 6.47.03 PM.png (2,308×1,462 px, 455 KB)

logstash link - 42 hits in last 12 hours

error_class TypeError
error_context.namespace Special
error_context.skin minerva
error_context.special_page EditWatchlist
error_context.version 1.41.0-wmf.1
error_context.wiki enwiki
level ERROR
message TypeError: Cannot read properties of undefined (reading 'top')
meta.dt 2023-03-29T01:50:41.288Z
meta.id 4f8fff7e-6176-41cf-8a46-52d52c1e2a08
meta.request_id 1fe02738-45ad-444f-ba32-ea598c7a6ed9
meta.stream mediawiki.client.error
normalized_message TypeError: Cannot read properties of undefined (reading 'top')
	
stack_trace
at n.scrollNearEnd  <anonymous>:182:229
at n._onScroll  <anonymous>:182:73
at OO.EventEmitter.emit  <anonymous>:279:656
at <anonymous>:126:743
at run  <anonymous>:359:987

QA Results - Beta

AC	Status	Details
1	✅	T333417#9325208

QA Results - Prod

AC	Status	Details
1	✅	T333417#9343400

Details

Other Assignee: Jdlrobson

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Scrolling empty Watchlist	Mabualruz	mediawiki/extensions/MobileFrontend	master	+5 -2

Customize query in gerrit

Related Objects

Mentioned In: T350416: Verify 1.42.0-wmf.5 deployment
Mentioned Here: T296863: TypeError: Cannot read properties of undefined (reading 'top')

Event Timeline

Etonkovidova created this task.Mar 29 2023, 2:02 AM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptMar 29 2023, 2:02 AM

Jdlrobson edited projects, added: Web-Team-Backlog-Archived, Wikimedia-production-error; removed: Web-Team-Backlog-Archived (Web Team FY2022-23 Q3 Sprint 6).Mar 29 2023, 5:15 PM

Jdlrobson added a project: MobileFrontend.

Umherirrender added a project: JavaScript.Mar 29 2023, 6:51 PM

Jdlrobson triaged this task as Low priority.Apr 3 2023, 8:49 PM

Jdlrobson edited projects, added: MobileFrontend (MobileFrontend Special Pages); removed: MobileFrontend.

Jdlrobson moved this task from Incoming to Groomed on the Web-Team-Backlog-Archived board.Apr 5 2023, 11:36 PM

• thcipriani moved this task from Untriaged to Mar 2023 on the Wikimedia-production-error board.Apr 13 2023, 3:49 PM

Jdlrobson moved this task from Groomed to Needs Prioritization (Tech) on the Web-Team-Backlog-Archived board.May 9 2023, 8:35 PM

Jdlrobson edited projects, added: Web-Team-Backlog-Archived (Needs Prioritization (Tech)); removed: Web-Team-Backlog-Archived.

Jdlrobson moved this task from Backlog to Remove mobile Watchlist special page on the Web-Team-Backlog-Archived (Needs Prioritization (Tech)) board.May 12 2023, 7:47 PM

The error rate has been rising to the point this is causing a lot of log spam.

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog-Archived (Web Team FY2023-24 Q2 Sprint 3) board.Nov 2 2023, 12:08 PM

Jdlrobson moved this task from Ready for Development to Incoming on the Web-Team-Backlog-Archived (Web Team FY2023-24 Q2 Sprint 3) board.Nov 6 2023, 6:47 PM

Jdlrobson moved this task from Incoming to Blocked on Others on the Web-Team-Backlog-Archived (Web Team FY2023-24 Q2 Sprint 3) board.Nov 6 2023, 6:57 PM

Jdlrobson moved this task from Blocked on Others to Incoming on the Web-Team-Backlog-Archived (Web Team FY2023-24 Q2 Sprint 3) board.Nov 6 2023, 7:00 PM

Jdlrobson set the point value for this task to 1.Nov 7 2023, 5:55 PM

Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog-Archived (Web Team FY2023-24 Q2 Sprint 3) board.

Change 971443 had a related patch set uploaded (by Mabualruz; author: Mabualruz):

[mediawiki/extensions/MobileFrontend@master] Scrolling empty Watchlist

https://gerrit.wikimedia.org/r/971443

gerritbot added a project: Patch-For-Review.Nov 7 2023, 7:04 PM

• Mabualruz claimed this task.Nov 7 2023, 7:04 PM

• Mabualruz moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (Web Team FY2023-24 Q2 Sprint 3) board.

• Mabualruz moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (Web Team FY2023-24 Q2 Sprint 3) board.

• Mabualruz updated Other Assignee, added: Jdlrobson.Nov 7 2023, 7:06 PM

Jdlrobson reassigned this task from • Mabualruz to Edtadros.Nov 7 2023, 9:37 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog-Archived (Web Team FY2023-24 Q2 Sprint 3) board.

Jdlrobson added a subscriber: • Mabualruz.

Change 971443 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Scrolling empty Watchlist

https://gerrit.wikimedia.org/r/971443

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.5; 2023-11-14).Nov 7 2023, 10:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 7 2023, 10:10 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

On mobile as a user without articles on Watchlist, log in and go to the Watchlist.
✅ AC1: Scroll the empty Watchlist - the Console will display the following error:

I tried on both Advanced Mode and non-Advanced, no errors appeared in the console.

screenshot 202.png (1,323×833 px, 109 KB)

screenshot 203.png (1,278×889 px, 116 KB)

Edtadros updated the task description. (Show Details)Nov 12 2023, 11:31 PM

Sign off involves verifying that the error rate has disappeared on logstash.

The error message is still firing even just checking for the last 2 hours. I will wait another 24 hours before sign off.

LGTM - clear drop off!:

KSarabia-WMF closed this task as Resolved.Nov 17 2023, 4:10 PM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

On mobile as a user without articles on Watchlist, log in and go to the Watchlist.
✅ AC1: Scroll the empty Watchlist - the Console will display the following error:

I tried on both Advanced Mode and non-Advanced, no errors appeared in the console.