Page MenuHomePhabricator

OOUI Toggles break screen reader support in mobile preferences and settings
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):
on mobile:

  • using a screen reader, navigate through a preference section
  • focus on a toggle

What happens?:
the screen reader narrates the state of the toggle switch, but does not read the title or label for the toggle.

What should have happened instead?:
the title and description of the option being toggled should be narrated. Try the same thing with checkboxes on desktop to experience the correct behavior.

Software version (skip for WMF-hosted wikis like Wikipedia):
N/A
Other information (browser name/version, screenshots, etc.):
It might be worth checking other OOUI toggle implementations to see if any of them maintain accessibility:
https://codesearch.wmcloud.org/deployed/?q=OO.ui.ToggleSwitchWidget&files=.*%5C.js&excludeFiles=&repos=

Event Timeline

I believe we hit desktop parity with T325574 and these tasks should have been merged. I will verify today.

Change 920339 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] Implement HTMLToggleSwitchField for mobile layout of preferences

https://gerrit.wikimedia.org/r/920339

I believe we hit desktop parity with T325574 and these tasks should have been merged. I will verify today.

I verified that I was misremembering!

Change 920339 merged by jenkins-bot:

[mediawiki/core@master] Implement HTMLToggleSwitchField for mobile layout of preferences

https://gerrit.wikimedia.org/r/920339

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/34de885f3a/w/