| Daimona | |
| Mar 30 2023, 4:03 PM |
| F48492966: Screen Recording 2024-04-24 at 2.33.21 PM.gif | |
| Apr 24 2024, 7:38 PM |
| F46843751: Screen Recording 2024-04-15 at 4.14.20 PM.gif | |
| Apr 15 2024, 9:18 PM |
| F46840881: Screen Recording 2024-04-15 at 3.29.43 PM.gif | |
| Apr 15 2024, 9:18 PM |
| F36934410: image.png | |
| Mar 30 2023, 4:03 PM |
| F36934403: image.png | |
| Mar 30 2023, 4:03 PM |
The current behaviour of Special:EnableEditRegistration and Special:EditEditRegistration when you submit the form is that if the data is valid, you see a page that only contains a success notice:
I'm wondering if we should also show the (updated) form below the notice. It would look something like this:
The idea being, you're immediately able to see the updated data, and make further changes if you want to. Unsure if it's a good thing to do, though.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Daimona | T312943 Update flow after enabling/editing registrations | |||
| Resolved | Daimona | T333579 Should Special:EditEventRegistration show the (updated) form upon successful submission |
Change #1019133 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/extensions/CampaignEvents@master] Show the form upon successfully enabling/editing registration
Change #1019133 merged by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] Show the form upon successfully enabling/editing registration
| Special:EditEventRegistration | Special:EnableEventRegistration |
 |  |
@Daimona this is working as stated in the Description. However, I don't think this flow makes as much sense on Special:EnableEventRegistration, because once the event is enabled, then the EnableEventRegistration form no longer works for that event. It could redirect to Special:EditEventRegistration or if we want to remain on this page after the event is enabled, then the Enable registration button should be disabled. But even this I don't think is a UX improvement on what was happening before this patch (as far as Special:EnableEventRegistration is concerned). While I do agree with the action of keeping the user on the page for EditEventRegistration, I think for EnableEventRegistration it just adds confusion.
@gonyeahialam @ifried thoughts on this?
Oh yes, you're absolutely right. For some reason, the existence of Special:Enable didn't cross my mind while working on this task. I'll revert it to the old behaviour.
Change #1019945 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/extensions/CampaignEvents@master] Do not show form on success on Special:EnableEventRegistration
Change #1019945 merged by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] Do not show form on success on Special:EnableEventRegistration
✅ Special:EditEventRegistration now shows the updated form upon successful submission.
The behavior of Special:EnableEventRegistration remains the same as it was before this merge - it does not show the form upon successful submission.
This is working as expected, marking as done / resolved.