Page MenuHomePhabricator

DefaultView: TypedList items that are expanded because they don't have collapsed mode sometimes don't show context Menu
Closed, ResolvedPublicBUG REPORT

Description

Description

Steps to reproduce:

  1. Go to https://wikifunctions.beta.wmflabs.org/w/index.php?title=Z10486&action=edit&view=default-view

Observed behavior:

  • Items cannot be removed

Expected behavior (Acceptance criteria):

  • On top of each item we should see context menu that allows for deletion

Devices and Design (URLs or screenshots, if applicable):

  • Desktop: ...
  • Small screens/mobile: ...

Completion checklist

Event Timeline

Change 904581 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Set ZObjectKeyValue expanded flag to true when there's no collapsed component

https://gerrit.wikimedia.org/r/904581

Change 904581 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Set ZObjectKeyValue expanded flag to true when there's no collapsed component

https://gerrit.wikimedia.org/r/904581

Checked - the item can be removed: the delete button is present and has a tool tip explaining the action:

Screen Shot 2023-05-16 at 12.46.13 PM.png (658×1 px, 105 KB)

@gengh

  • Should there be a "Cancel" button? A deleted item (if the action is not published) cannot be restored unless a user reloads a page. E.g. Edit Function page has "Cancel" button.
DVrandecic subscribed.

This is good. A cancel button would be nice, but let's make a new task for that. A user can always leave the page if they want to cancel.

This is good. A cancel button would be nice, but let's make a new task for that. A user can always leave the page if they want to cancel.

Thx, @DVrandecic - filed as T336877.