Change 905314 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Point out the limited width control

https://gerrit.wikimedia.org/r/905314

@Jdlrobson @ovasileva The only behaviour I found odd in the demo was after toggling to full width and getting the “You have switched your layout to full width. To go back to limited width, press this button” message, and then toggling back to limited width, the message still remains.

This results in a message saying you’ve switched to full width when you are actually viewing limited width.

The behaviour I would expect would be for the tooltip to fade out once I had switched back to limited width.

Reviewed the logic in the task description and it makes sense. Maybe we had an issue with the original patchdemo?

Change 905314 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] Point out the limited width control

Reason:

To be worked on next sprint. Feel free to reuse the ideas here.

https://gerrit.wikimedia.org/r/905314

For cleaner stats this could be made symmetric for the two possible states:

On page load for users who have previously interacted with the toggle:

• "You have set your layout to {full | limited} width. To switch to {limited | full} width, press this button."

Likewise with cookies disabled:

• Show a popup after interacting with the button regardless of the resulting state.

@Jdrewniak @KSarabia-WMF and I met on Thursday, We think this should be split into multiple tasks as follows:

1. This task as it is, without addressing server side rendering or performance issues (we already load jQuery and OOUI would not be a big hit especially for a non long lasting feature), for the point of cookies disabled browser local storage might be another option (optional) . and agreed on 5 points
2. Performance tweaks for on page load OOUI library https://phabricator.wikimedia.org/T334366 Need to vote on the points here
3. On page load Javascript files load performance Tweaking https://phabricator.wikimedia.org/T334367
4. OOUI widgets replacements implemented in vector following codex guidelines https://phabricator.wikimedia.org/T334368

The 1st tow covers all we talked about and need for shipping this, the 3rd and 4th are possible followups for more generic use.

Change 905314 restored by Jdlrobson:

[mediawiki/skins/Vector@master] Point out the limited width control

https://gerrit.wikimedia.org/r/905314

@KieranMcCann Design clarification, should the popup have a close button? And should it be dismissed automatically after a certain time or when the users clicks elsewhere similar to the pinnable element notification? This is what it looks like right now in the patchdemo/WIP patch @Jdlrobson put together https://jmp.sh/XHYgx8G5

I've got some preparation patches that need review before I continue: one, two and three

In T333601#8769405, @bwang wrote:

@KieranMcCann Design clarification, should the popup have a close button? And should it be dismissed automatically after a certain time or when the users clicks elsewhere similar to the pinnable element notification? This is what it looks like right now in the patchdemo/WIP patch @Jdlrobson put together https://jmp.sh/XHYgx8G5

the popup should be dismissible (I think a close button is okay, but maybe @KieranMcCann would have to confirm). For the first popup, it would be dismissed when the user clicks somewhere.

Change 907944 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] POC: Add custom limited width popup

https://gerrit.wikimedia.org/r/907944

Relaying a convo I had with @ovasileva, so I believe the expectation is that all the popups should be dismissed when the user clicks elsewhere. For the popups with this text "You have switched your layout to full width...", they will be automatically dismissed after 4 seconds similar to the pinnable element popups.

And I believe the close button is still up to @KieranMcCann?

In T333601#8779409, @bwang wrote:

Relaying a convo I had with @ovasileva, so I believe the expectation is that all the popups should be dismissed when the user clicks elsewhere. For the popups with this text "You have switched your layout to full width...", they will be automatically dismissed after 4 seconds similar to the pinnable element popups.

And I believe the close button is still up to @KieranMcCann?

That all sounds good.

Change 905314 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Point out the limited width control

https://gerrit.wikimedia.org/r/905314

@bwang Sorry just catching up after being on leave. I would be tempted to still include the close button.

Change 909396 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] [beta cluster] Enable indicators on page load

https://gerrit.wikimedia.org/r/909396

Hey @Jdrewniak could you help us merge https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/909396 so we can get this into QA?

Change 907944 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Add custom limited width popup

https://gerrit.wikimedia.org/r/907944

Change 909396 merged by jenkins-bot:

[operations/mediawiki-config@master] [beta cluster] Enable indicators on page load

https://gerrit.wikimedia.org/r/909396

Looks good