Page MenuHomePhabricator

NWE template preview in Vector 2022 is broken
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue:

  • Edit a template page on Wikipedia, using the 2017-wikitext-editor (NWE) and Vector 2022.
  • Preview the template on any page using Preview page with this template.
  • Example: preview de:Template:Fichier Décès on page Gérard Calvi.

What happens?:
The resulting page is misaligned on screens wider than 1000px: the title (h1) and the catlinks are outside of mw-body-content, so the main content will get squeezed into a small column on the right of the screen.

What should have happened instead?:
The preview should show a realistic example of the resulting page, like in other skins.

Other information:
Maybe related to T328783. First reported here on dewiki.

Event Timeline

Editing Template:Infobox film on test.wiki and "Previewing page What We Do in the Shadows with this template". Got this:

image.png (1×2 px, 228 KB)

It makes template testing really hard. Something's wrong with that mw-body grid.

Pols12 added subscribers: ovasileva, Pols12.

This regression has probably the same cause than T327778.

Change #1121090 had a related patch set uploaded (by Lucas Werkmeister; author: Lucas Werkmeister):

[mediawiki/extensions/TemplateSandbox@master] Fix layout in Vector 2022 VisualEditor

https://gerrit.wikimedia.org/r/1121090

This regression has probably the same cause than T327778.

Indeed, thanks for that pointer!

Change #1121090 merged by jenkins-bot:

[mediawiki/extensions/TemplateSandbox@master] Fix layout in Vector 2022 VisualEditor

https://gerrit.wikimedia.org/r/1121090

matmarex removed a project: Patch-For-Review.
matmarex subscribed.

The fix will be deployed to Wikimedia wikis this week, on the usual schedule.

Can confirm that it seems to be fixed now \o/