Page MenuHomePhabricator
Create Task
Maniphest T333687

Warning: SQLPlatform::isWriteQuery fallback to regex (ContentTranslation)
Closed, ResolvedPublic
Actions

Description

#4 /srv/mediawiki/php-1.41.0-wmf.2/extensions/ContentTranslation/includes/Translator.php(90): Wikimedia\Rdbms\DBConnRef->query(string, string)
#5 /srv/mediawiki/php-1.41.0-wmf.2/extensions/ContentTranslation/includes/ActionApi/ApiQueryContentTranslation.php(195): ContentTranslation\Translator->getLanguages(string)
#6 /srv/mediawiki/php-1.41.0-wmf.2/extensions/ContentTranslation/includes/ActionApi/ApiQueryContentTranslation.php(63): ContentTranslation\ActionApi\ApiQueryContentTranslation->run()

This call to ->query() should either be ported to a different method, or specify one of the ISQLPlatform::QUERY_CHANGE_* constants if that’s not possible.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Translator: Mark query as read-onlymediawiki/extensions/ContentTranslationmaster+2 -1
Translator: Use SelectQueryBuilder, UnionQueryBuildermediawiki/extensions/ContentTranslationmaster+17 -15
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 31 2023, 1:42 PM
Lucas_Werkmeister_WMDE added a comment.Mar 31 2023, 1:44 PM

Ok, this is another UNION case, like T332941 and T332942.

$res = $dbr->query( $dbr->unionQueries( $queries, false ), __METHOD__ );
gerritbot added a comment.Mar 31 2023, 1:54 PM

Change 904799 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/ContentTranslation@master] Translator: Mark query as read-only

https://gerrit.wikimedia.org/r/904799

gerritbot added a project: Patch-For-Review.Mar 31 2023, 1:54 PM
Lucas_Werkmeister_WMDE claimed this task.Mar 31 2023, 2:06 PM
Lucas_Werkmeister_WMDE mentioned this in T333686: Warning: SQLPlatform::isWriteQuery fallback to regex (GoogleNewsSitemap).Mar 31 2023, 2:21 PM
Lucas_Werkmeister_WMDE renamed this task from Warning: Wikimedia\Rdbms\Platform\SQLPlatform::isWriteQuery fallback to regex (ContentTranslation) to Warning: SQLPlatform::isWriteQuery fallback to regex (ContentTranslation).Mar 31 2023, 2:26 PM
Mainframe98 added a project: ContentTranslation.Mar 31 2023, 5:16 PM
• larissagaulia moved this task from Inbox, needs triage to Radar on the Performance-Team board.Apr 3 2023, 4:36 PM
• larissagaulia edited projects, added Performance-Team (Radar); removed Performance-Team.
gerritbot added a comment.Apr 12 2023, 4:12 PM

Change 908279 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/ContentTranslation@master] Translator: Use SelectQueryBuilder, UnionQueryBuilder

https://gerrit.wikimedia.org/r/908279

gerritbot added a comment.Apr 13 2023, 12:24 PM

Change 908279 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Translator: Use SelectQueryBuilder, UnionQueryBuilder

https://gerrit.wikimedia.org/r/908279

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.5; 2023-04-17).Apr 13 2023, 1:00 PM
gerritbot added a comment.Apr 13 2023, 2:36 PM

Change 904799 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/extensions/ContentTranslation@master] Translator: Mark query as read-only

Reason:

If543f066fd was merged instead.

https://gerrit.wikimedia.org/r/904799

Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 13 2023, 2:38 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 13 2023, 3:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits