Page MenuHomePhabricator

Ask for confirmation when deleting an in-progress translation
Closed, ResolvedPublic

Description

After the initial implementation of in-progress lists (T260165) for the mobile experience, the discard action (exposed with a "trash can" icon) is applied without previous warning for the user. This ticket proposes to show a confirmation dialog similar to the one that is shown on desktop:

en.wikipedia.org_w_index.php_title=Special_ContentTranslation&campaign=contributionsmenu&to=en.png (286×811 px, 50 KB)

Are you sure you want to permanently delete this translation?
[Cancel] [Delete translation]

Dashboard lists - In progress.png (768×1 px, 202 KB)

Event Timeline

Pginer-WMF triaged this task as Medium priority.Mar 31 2023, 1:58 PM
Pginer-WMF created this task.
Pginer-WMF updated the task description. (Show Details)

Change 920634 had a related patch set uploaded (by Nik Gkountas; author: Nik Gkountas):

[mediawiki/extensions/ContentTranslation@master] SX: Ask for confirmation when deleting an in-progress translation

https://gerrit.wikimedia.org/r/920634

Change 920634 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] SX: Ask for confirmation when deleting an in-progress translation

https://gerrit.wikimedia.org/r/920634

Change 932684 had a related patch set uploaded (by Santhosh; author: Santhosh):

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20230626

https://gerrit.wikimedia.org/r/932684

Change 932684 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] CX3 Build 0.2.0+20230626

https://gerrit.wikimedia.org/r/932684

In general, the dialog is showing as expected.

There is one small discrepancy when comparing it with the current desktop experience about the input focus. In the current implementation the input focus is not going to any element of the dialog. Instead, the "Delete translation" button should get the input focus. In this way it can be confirmed by pressing enter.


Another issue was identified but seems not directly connected, and was reported in a separate ticket: T342739: Translations started on desktop cannot be deleted on mobile

Now that a new ticket for the input focus has been created (T347014), I believe we can close this task as resolved.