Page MenuHomePhabricator

Echo: Replace mediawiki.ui variables with mediawiki.skin.variables
Closed, ResolvedPublic

Description

Background

As outlined in parent task T332541 MediaWiki core v1.41.0 on provides Codex design tokens via mediawiki.skin.variables.
They are much more powerful and comprehensive and aim to replace both, 'mediawiki.ui/variables' and WikimediaUI Base.

Notifications have used both, mediawiki.ui variable files and a subset of WikimediaUI Base vars interchangeably and extensively.
As we're touching a number of files and also replace some values that are close, but not 1:1 equivalent, this task is providing the venue to discuss possible visual amendments.

Goal

Replace all calls of the former central variable files
While at it, also provide best practice usage of Codex design tokens. For example colors shouldn't be directly referenced in code (don't: color: @wmui-color-base30;, do: color: @color-subtle)

Developer/designer notes
  • color: @wmui-color-base30; (#72777d) is replaced by color: @color-subtle (#54595d) as only disabled and placeholder elements receive 72777d in Codex latest token definition.
Open questions
Acceptance criteria for done
  • Replace all calls to 'mediawiki.ui/variables'
    • Replace all mediawiki.ui variables
  • Remove WikimediaUI Base variables
  • Replace close static values, starting with background-colors, colors, opacities, border properties and border-radius

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 905204 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] mediawiki.less: Deprecate Codex design tokens replaced variables

https://gerrit.wikimedia.org/r/905204

Volker_E changed the task status from Open to In Progress.Apr 17 2023, 1:58 PM
Restricted Application triaged this task as High priority. · View Herald TranscriptApr 19 2023, 9:13 PM
Volker_E claimed this task.
Volker_E updated the task description. (Show Details)