Page MenuHomePhabricator
Create Task
Maniphest T333847

PageTranslationDeletePage: do not display page titles with underscores
Closed, ResolvedPublic
Actions

Description

Special:PageTranslationDeletePage displays the page title to be deleted with underscores in the Page name field of the deletion form, as opposed to e.g. the Move form. Should probably not be using them and display instead the page title with spaces if it has them.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
DeleteTranslatableBundleSpecialPage: show canonical titlemediawiki/extensions/Translatemaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

MarcoAurelio created this task.Apr 3 2023, 3:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 3 2023, 3:31 PM
MarcoAurelio merged a task: T334896: PageTranslationDeletePage: Do not display the page title with underscores.Apr 19 2023, 11:31 PM
MarcoAurelio added a project: good first task.
MarcoAurelio updated the task description. (Show Details)
Base subscribed.Apr 20 2023, 12:16 AM
Nikerabbit triaged this task as Lowest priority.Apr 24 2023, 11:14 AM
Nikerabbit removed a project: Language-Team.
Nikerabbit moved this task from Backlog to page translation on the MediaWiki-extensions-Translate board.
Nikerabbit subscribed.

I recall looking at this at some point and I am doubting whether this is a good first task.

gerritbot added a comment.Apr 29 2023, 10:27 AM

Change 913510 had a related patch set uploaded (by Tacsipacsi; author: Tacsipacsi):

[mediawiki/extensions/Translate@master] DeleteTranslatableBundleSpecialPage: show canonical title

https://gerrit.wikimedia.org/r/913510

gerritbot added a project: Patch-For-Review.Apr 29 2023, 10:27 AM
Tacsipacsi changed the task status from Open to In Progress.Apr 29 2023, 10:28 AM
Tacsipacsi claimed this task.
Tacsipacsi subscribed.
In T333847#8801002, @Nikerabbit wrote:

I recall looking at this at some point and I am doubting whether this is a good first task.

Actually it is.

Nikerabbit added a comment.Apr 29 2023, 1:27 PM

Happy to be proven wrong.

gerritbot added a comment.May 3 2023, 10:46 AM

Change 913510 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] DeleteTranslatableBundleSpecialPage: show canonical title

https://gerrit.wikimedia.org/r/913510

Maintenance_bot removed a project: Patch-For-Review.May 3 2023, 11:10 AM
abi_ added a project: Language-Team (Language-2023-April-June).May 3 2023, 11:11 AM
abi_ moved this task from Quarter Backlog to Check after deployment on the Language-Team (Language-2023-April-June) board.
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 7:02 AM
Tacsipacsi added a comment.May 17 2023, 5:59 PM

Can someone test this in production? I don’t have admin right on any production wiki that has Translate.

Base added a comment.May 17 2023, 8:27 PM

@Tacsilacsi, I don't know what it looked like before, but I don't see any underscores now:

Screenshot_20230517_232636_Firefox.png (1×1 px, 315 KB)

abi_ closed this task as Resolved.May 19 2023, 5:27 AM
abi_ moved this task from Check after deployment to Done on the Language-Team (Language-2023-April-June) board.
abi_ subscribed.

Also checked on translatewiki.net:

image.png (494×854 px, 39 KB)

Thanks @Tacsipacsi

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits