Page MenuHomePhabricator

Improve error message about Edit Policy when creating objects when Edit Policy is hidden in form
Closed, ResolvedPublicFeature

Description

In https://www.mediawiki.org/wiki/Talk:Phabricator/Help/2023#Creating_component, a user who is a member of acl*Project-Admins but not a member of Trusted-Contributors wanted to create a new project by using https://phabricator.wikimedia.org/project/edit/form/4/

Per https://phabricator.wikimedia.org/transactions/editengine/projects.project/defaults/4/ we hide the Editable By field which is set to Trusted-Contributors due to past vandalism.

This triggered the error message “You can not select this edit policy, because you would no longer be able to edit the object” although the user had no option to see or select the edit policy.

This is confusing.
We may want to adjust the error message via an override in https://gerrit.wikimedia.org/r/plugins/gitiles/operations/puppet/+/refs/heads/production/modules/phabricator/data/fixed_settings.yaml .
Note that this error message still needs to be generic as the same issue in theory could also happen with other groups/configurations that do not involve Trusted-Contributors.

Details

Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Do not imply that user actively selected object policyrepos/phabricator/deployment!8aklapperaklapper-wmf/T333955wmf/stable
Customize query in GitLab

Event Timeline

Aklapper triaged this task as Low priority.
Aklapper added a project: Voice & Tone.
Aklapper edited projects, added Phabricator (2023-10-03); removed Phabricator.
Aklapper added a subscriber: brennen.

I assume this got deployed in the 2023-10-03 deployment. (@brennen: Please correct me if I am wrong as it's not listed in T348007)

I believe this went out 2023-09-26, but at any rate it is definitely live now.