performance: consider removing curly
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Physikerwelt
	Apr 4 2023, 3:51 PM

Project Tags

Referenced Files

None

Subscribers

Description

When looking at typical texvcjs parse trees one sees quite a few curly elements, those always have a single array element that might be empty. I think one could replace curly with an array-element and add a property, e.g., hasCurlies, to texArray. While this would add an if statement to the rendering call of texarray, I guess it would overall improve performance, reduce the size of the codebase and increase the readability of the codebase.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Fix call to isCurly of null	Physikerwelt	mediawiki/extensions/Math	master	+1 -1
	Remove curly	Physikerwelt	mediawiki/extensions/Math	master	+100 -154

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		Stegmujo	T310373 Make Mathoid Client a standalone class
Open		None	T327098 Implement Math Accessibility Features necessary for Intent attribute usage
Resolved		Physikerwelt	T302628 Implement native MathML rendering in Math
Resolved		Physikerwelt	T310211 Deliver visible MathML to the browser
Resolved		Stegmujo	T331047 Implicitly generate Math elements in MathML from the TexVC parsetree
Resolved		mmartorana	T354136 Application Security Review Request: MathJax
Resolved		Physikerwelt	T360176 Replace -s with _s in i18n math mode strings
Resolved		Stegmujo	T311606 merge texvcinfo into texvcjs
Duplicate		Stegmujo	T311809 Delete texvcinfo content
Resolved		Stegmujo	T312528 Convert Grammar related javascript to php in texvcjs
Resolved		Stegmujo	T315978 Reminder Final Checks in Implementation
Resolved		Stegmujo	T321599 Improve Perfomance of TexVC PHP in Math
Resolved		Physikerwelt	T333973 performance: consider removing curly
Resolved		Stegmujo	T312089 Enable generation of php-parsers in texvcjs
Duplicate		Stegmujo	T312529 Create MML interfaces for texvcjs
Duplicate		Stegmujo	T312530 Create only MathML setting in Math Extension
Declined		Stegmujo	T312762 Check technologies for LateX to MathML conversion
Declined		Stegmujo	T310372 Create batch rendering abstraction
Resolved		Stegmujo	T327386 Create a Full Coverage Test for TexVC(PHP)
Resolved		Stegmujo	T327388 Generate and Update Reference MathML for the current Tests
Resolved		None	T327391 Fix the TexVC(PHP) Parse tree related cases
Resolved		Stegmujo	T327392 Implement Parsing functionality and mappings for full MathML coverage
Resolved		Stegmujo	T327393 Implement a comparison algorithm for automated testing which can compare different MathML outputs
Resolved		Physikerwelt	T346584 Enable native MathML rendering mode in beta
Resolved		Physikerwelt	T346795 User Feedback to MathML implementation in Math extension
Duplicate		None	T348615 Implement User Feedback to Round One
Resolved		Stegmujo	T348791 native: \begin{align} should align left
Resolved		Stegmujo	T348793 native: \left( and friends should generate stretchy mo-elements
Resolved		Stegmujo	T348971 Create correct sized fences around smallmatrix
Resolved		Stegmujo	T349822 Remove mstyle around spacing elements
Resolved		Stegmujo	T349825 Fix incorrect child counts in MathML for some elements
Resolved		Stegmujo	T349906 Fix error value in columnspacing attribute in mtable
Resolved		Stegmujo	T350021 Add invisible apply character after functions
Resolved		Stegmujo	T350491 Add space in liminf and limsup
Resolved		Stegmujo	T350735 native: \tbinom{n}{k} is broken
Resolved		SalixAlba	T350736 native: align environement still not optimal
Declined		Physikerwelt	T350737 native:chem expression <chem>A ->[{}\atop\ce{+H2O}] B</chem> fail
Resolved		Stegmujo	T350738 native: distinction in bracket sizes ( \bigl( \Bigl( too small?
Resolved	BUG REPORT	Stegmujo	T352196 native: Rendering error in Letters written in Blackboard bold
Resolved	BUG REPORT	Stegmujo	T352536 native: Rendering for MathCal not working on Chrome
Resolved	BUG REPORT	Physikerwelt	T352608 native: Rendering error - Align is not left-aligned in chrome
Resolved	BUG REPORT	Physikerwelt	T352609 native: \operatorname effect does not propagate into \widetilde arguments
Resolved	BUG REPORT	Physikerwelt	T352697 native: Rendering error in powers and indices
Open	BUG REPORT	HamidRahkooy	T352698 native: Rendering error in overline; the line is too short in Chrome
Resolved	BUG REPORT	Physikerwelt	T352699 native: Rendering error in \operatorname{erf}^{-1}
Resolved	BUG REPORT	Physikerwelt	T353340 native: Rendering error rm font does not propagate into child nodes
Resolved		Physikerwelt	T355999 native: Check debug console on Help:MathTestNative
Resolved		Physikerwelt	T357343 Incorrect mo in \sin \log_a
Resolved		Physikerwelt	T350787 Deploy native on a few pilot wikis
Resolved	BUG REPORT	Stegmujo	T351850 \nolimits renders incorrectly in native MathML
Resolved		Stegmujo	T351907 Closing bracket size too small
Invalid		None	T352735 Ensure that \bigl and friends are closed with corresponding right elements

Event Timeline

Physikerwelt created this task.Apr 4 2023, 3:51 PM

Restricted Application added a project: Math. · View Herald TranscriptApr 4 2023, 3:51 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Physikerwelt added a parent task: T321599: Improve Perfomance of TexVC PHP in Math.Apr 4 2023, 3:51 PM

Physikerwelt moved this task from Inbox to Needs community consensus on the Math board.

I think when working in debugger with the codebase (speaking for TexVC-PHP which is similar atm) then it is fine to have the curly element when viewing the parsetrees. TexArray with a property could obfuscate things in this matter.

Physikerwelt claimed this task.Nov 30 2023, 9:25 AM

Physikerwelt triaged this task as Low priority.

Physikerwelt moved this task from Needs community consensus to Inbox on the Math board.

Physikerwelt moved this task from Backlog to far future (maybe) on the Texvcjs board.

Change 1004311 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/Math@master] Remove curly (WIP)

https://gerrit.wikimedia.org/r/1004311

gerritbot added a project: Patch-For-Review.Feb 17 2024, 11:02 PM

Change #1004311 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Remove curly

https://gerrit.wikimedia.org/r/1004311

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).Apr 9 2024, 11:00 AM