Page MenuHomePhabricator

Enable the multiple organizers feature in production
Closed, ResolvedPublic

Description

Acceptance criteria

  • The multiple organizers feature works in production (testwiki, test2wiki, meta)

Checklist

  • Add the campaignevents-organize-events right to the campaignevents-beta-tester group, and remove it from the user group in the metawiki config
  • Set $wgCampaignEventsEnableMultipleOrganizers to true for all prod wikis
  • Remove the feature flag from the extension
  • Remove the feature flag from the Wikimedia config

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptApr 5 2023, 12:36 PM

how does adding additional organizers impact data storage?
Are we adding additional columns to the table or changing the data type of organizer_username so that we can store the organizer names as a tuple or ?

how does adding additional organizers impact data storage?
Are we adding additional columns to the table or changing the data type of organizer_username so that we can store the organizer names as a tuple or ?

The relationship between campaign_events and ce_organizers becomes one-to-many, so there'll be >=1 rows in the latter table associated to each event.

Change 909001 had a related patch set uploaded (by Cmelo; author: Cmelo):

[mediawiki/extensions/CampaignEvents@master] Remove multi organizers feature flag

https://gerrit.wikimedia.org/r/909001

Change 909401 had a related patch set uploaded (by Cmelo; author: Cmelo):

[operations/mediawiki-config@master] Remove multi organizers feature flag

https://gerrit.wikimedia.org/r/909401

Change 910055 had a related patch set uploaded (by Cmelo; author: Cmelo):

[operations/mediawiki-config@master] Add new user right campaignevents-organize-events

https://gerrit.wikimedia.org/r/910055

Change 910056 had a related patch set uploaded (by Cmelo; author: Cmelo):

[operations/mediawiki-config@master] Set multi organizer feature flag to true

https://gerrit.wikimedia.org/r/910056

Change 910055 merged by jenkins-bot:

[operations/mediawiki-config@master] metawiki: Give campaignevents-organize-events to campaignevents-beta-tester only

https://gerrit.wikimedia.org/r/910055

Mentioned in SAL (#wikimedia-operations) [2023-04-27T13:05:10Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:910055|metawiki: Give campaignevents-organize-events to campaignevents-beta-tester only (T334088)]]

Mentioned in SAL (#wikimedia-operations) [2023-04-27T13:06:38Z] <samtar@deploy1002> samtar and cmelo: Backport for [[gerrit:910055|metawiki: Give campaignevents-organize-events to campaignevents-beta-tester only (T334088)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-04-27T13:20:18Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:910055|metawiki: Give campaignevents-organize-events to campaignevents-beta-tester only (T334088)]] (duration: 15m 07s)

Change 910056 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable $wgCampaignEventsEnableMultipleOrganizers in production

https://gerrit.wikimedia.org/r/910056

Mentioned in SAL (#wikimedia-operations) [2023-04-27T13:26:44Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:910056|Enable $wgCampaignEventsEnableMultipleOrganizers in production (T334088)]]

Mentioned in SAL (#wikimedia-operations) [2023-04-27T13:28:17Z] <samtar@deploy1002> samtar and cmelo: Backport for [[gerrit:910056|Enable $wgCampaignEventsEnableMultipleOrganizers in production (T334088)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet

Change 912867 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[operations/mediawiki-config@master] beta: Restore campaignevents-organize-events right for all users

https://gerrit.wikimedia.org/r/912867

Mentioned in SAL (#wikimedia-operations) [2023-04-27T14:05:20Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:910056|Enable $wgCampaignEventsEnableMultipleOrganizers in production (T334088)]] (duration: 38m 35s)

Change 912867 merged by jenkins-bot:

[operations/mediawiki-config@master] beta: Restore campaignevents-organize-events right for all users

https://gerrit.wikimedia.org/r/912867

Hey @Daimona @cmelo @vaughnwalters do you all think this needs another round of testing, now that feature flag has been removed? Or are we ready for design sign-off?

Hey @Daimona @cmelo @vaughnwalters do you all think this needs another round of testing, now that feature flag has been removed? Or are we ready for design sign-off?

I think a round of testing wouldn't hurt, but after that, we still need to make a couple code changes, as well as another deployment, as per the checklist in the task description, so it would have to go back to in progress after testing, or we can create a separate task. I'll leave that up to @cmelo.

Hey @Daimona @cmelo @vaughnwalters do you all think this needs another round of testing, now that feature flag has been removed? Or are we ready for design sign-off?

Yep whenever dev is done with this I would like it to go in QA before going to design sign off

Change 909001 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Remove multi organizers feature flag

https://gerrit.wikimedia.org/r/909001

Change 924488 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[operations/mediawiki-config@master] prod: Remove $wgCampaignEventsEnableMultipleOrganizers

https://gerrit.wikimedia.org/r/924488

Change 909401 merged by jenkins-bot:

[operations/mediawiki-config@master] beta: Remove $wgCampaignEventsEnableMultipleOrganizers

https://gerrit.wikimedia.org/r/909401

Change 924488 merged by jenkins-bot:

[operations/mediawiki-config@master] prod: Remove $wgCampaignEventsEnableMultipleOrganizers

https://gerrit.wikimedia.org/r/924488

Mentioned in SAL (#wikimedia-operations) [2023-05-30T13:40:53Z] <tgr@deploy1002> Started scap: Backport for [[gerrit:924488|prod: Remove $wgCampaignEventsEnableMultipleOrganizers (T334088)]]

Mentioned in SAL (#wikimedia-operations) [2023-05-30T13:42:27Z] <tgr@deploy1002> tgr and daimona: Backport for [[gerrit:924488|prod: Remove $wgCampaignEventsEnableMultipleOrganizers (T334088)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-05-30T13:57:07Z] <tgr@deploy1002> Finished scap: Backport for [[gerrit:924488|prod: Remove $wgCampaignEventsEnableMultipleOrganizers (T334088)]] (duration: 16m 13s)

Daimona removed a project: Patch-For-Review.

@vaughnwalters This is ready for the last round of QA now. There should be no functional differences, but the multiple organizers feature should now work without setting the feature flag.

vaughnwalters closed this task as Resolved.EditedJun 1 2023, 7:51 PM
vaughnwalters claimed this task.

Multiple organizers feature works correctly on testwiki, test2wiki, meta

Pulled down a fresh version of the local environment (including a new LocalSettings.php) and multiple organizers works correctly without setting a feature flag. Moving to design sign off.

Screenshot 2023-06-01 at 2.41.53 PM.png (1ร—1 px, 180 KB)

@cmelo @Daimona When you remove the only event organiser from the form field it shows you the error message but the error message doesn't go away once you add an organiser

@cmelo @Daimona When you remove the only event organiser from the form field it shows you the error message but the error message doesn't go away once you add an organiser

Filed T338635 so that the bug won't block this task.

@cmelo @Daimona When you remove the only event organiser from the form field it shows you the error message but the error message doesn't go away once you add an organiser

Filed T338635 so that the bug won't block this task.

Okay, thanks