Page MenuHomePhabricator
Create Task
Maniphest T334261

It should be possible to disable Math preview type
Closed, ResolvedPublic
Actions

Assigned To
phuedx
Authored By
Jdlrobson
Apr 6 2023, 10:05 PM
Tags
Referenced Files
F41666418: Screenshot 2024-01-11 at 22.06.40.png
Jan 11 2024, 9:08 PM
F41666414: math.gif
Jan 11 2024, 9:02 PM
F41666364: Screenshot 2024-01-11 at 21-45-40 Preferences - Wikipedia the free encyclopedia.png
Jan 11 2024, 8:50 PM
F41665443: Screenshot 2024-01-11 at 10.35.20.png
Jan 11 2024, 10:43 AM
F41665439: Screenshot 2024-01-11 at 10.36.37.png
Jan 11 2024, 10:43 AM
F41665374: Screenshot 2024-01-11 at 11.03.23.png
Jan 11 2024, 10:06 AM
Subscribers
Aklapper
Andreg-p
Jdlrobson
phuedx
Physikerwelt
SalixAlba

Description

Currently the Math preview type (added in T208758) is unconditionally registered and the user has no way to disable it in the same way they disable page previews despite there being a settings config visible.

Example page:
https://en.wikipedia.beta.wmflabs.org/wiki/Mass%E2%80%93energy_equivalence

This will require a change in the Popups extension.
When that change is done it should be as straightforward as adding a preference and some messages (example https://github.com/jdlrobson/mediawiki-skins-skinjson/pull/18)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Should be possible to disable the Math previewmediawiki/extensions/Mathmaster+32 -8
Generalize settings codemediawiki/extensions/Popupsmaster+197 -212
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Apr 6 2023, 10:05 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2023, 10:05 PM
Jdlrobson updated the task description. (Show Details)Apr 6 2023, 10:06 PM
Jdlrobson updated the task description. (Show Details)Apr 6 2023, 10:26 PM
Jdlrobson updated the task description. (Show Details)Apr 6 2023, 10:33 PM
gerritbot added a comment.Apr 6 2023, 10:34 PM

Change 859574 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Generalize settings code

https://gerrit.wikimedia.org/r/859574

gerritbot added a project: Patch-For-Review.Apr 6 2023, 10:34 PM
Jdlrobson mentioned this in T345261: Build popup setting dialog with OOUI elements.Sep 5 2023, 10:09 PM
gerritbot added a comment.Oct 17 2023, 3:42 PM

Change 859574 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Generalize settings code

https://gerrit.wikimedia.org/r/859574

gerritbot added a comment.Oct 17 2023, 11:31 PM

Change 966647 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Math@master] WIP: Should be possible to disable preview

https://gerrit.wikimedia.org/r/966647

gerritbot added a comment.Nov 10 2023, 1:29 AM

Change 967306 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Generalize settings code (attempt 2)

https://gerrit.wikimedia.org/r/967306

Jdlrobson assigned this task to phuedx.Nov 22 2023, 12:49 AM
Jdlrobson added subscribers: phuedx, Physikerwelt.

@Physikerwelt https://gerrit.wikimedia.org/r/966647 should be ready for testing and review. @phuedx and I are working on this in a volunteer capacity and I made a mistake in the original version of https://gerrit.wikimedia.org/r/967306, so sorry this is taking so long. Hopefully the new patch works as advertised.

@phuedx let me know if you want to chat through these patches at any time.

gerritbot added a comment.Nov 22 2023, 12:51 AM

Change 966647 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Math@master] Should be possible to disable the Math preview

https://gerrit.wikimedia.org/r/966647

Physikerwelt added a comment.EditedJan 11 2024, 10:06 AM

Thank you. I tested on beta.

Screenshot 2024-01-11 at 11.03.23.png (690×1 px, 85 KB)

I don't see an option for math with Chrome. Note that the popups don't work at all in Firefox with MathML.

phuedx added a comment.Jan 11 2024, 10:43 AM
In T334261#9452470, @Physikerwelt wrote:

I don't see an option for math with Chrome.

I see the following in my browser's console (Chrome v120.0.6099.199, Firefox v121.0.1), when I visit https://en.wikipedia.beta.wmflabs.org/wiki/Mass%E2%80%93energy_equivalence:

[Popups] No setting for math registered. Please create message with key "popups-settings-option-math" if this is a mistake.

IIRC we don't show the option to toggle the preview type if we can't show a message.

Note that the popups don't work at all in Firefox with MathML.

I see the following on the above page in Firefox v121.0.1:

Screenshot 2024-01-11 at 10.36.37.png (2×2 px, 1 MB)

and on the Polar bear page:

Screenshot 2024-01-11 at 10.35.20.png (2×2 px, 1 MB)

Physikerwelt added a comment.Jan 11 2024, 10:49 AM

I see the problem is not related to firefox but to MathML rendering. I added a dedicated test section on

https://en.wikipedia.beta.wmflabs.org/wiki/Mass%E2%80%93energy_equivalence

Jdlrobson added a comment.Jan 11 2024, 4:56 PM

@Physikerwelt https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Math/+/966647 has not been merged yet.

gerritbot added a comment.Jan 11 2024, 8:32 PM

Change 966647 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Should be possible to disable the Math preview

https://gerrit.wikimedia.org/r/966647

Physikerwelt added a comment.Jan 11 2024, 8:50 PM

As a logged-in user, everything works as expected. The setting is here:

Screenshot 2024-01-11 at 21-45-40 Preferences - Wikipedia the free encyclopedia.png (4×3 px, 1 MB)

However, without logging in I could not change if popups occur or not. I also added action=purge. When I tried adding debug=true the popup didn't show up (even after some seconds of waiting).

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.14; 2024-01-16).Jan 11 2024, 9:00 PM
Physikerwelt moved this task from Inbox to Code Review on the Math board.Jan 11 2024, 9:01 PM
Physikerwelt added subscribers: Andreg-p, SalixAlba.

@SalixAlba @Andreg-p do you think we should notify users about this upcoming change?

Jdlrobson added a comment.Jan 11 2024, 9:02 PM

WFM?

math.gif (825×1 px, 1 MB)

Physikerwelt added a comment.Jan 11 2024, 9:08 PM

... probably the magic of some browser cache...

Screenshot 2024-01-11 at 22.06.40.png (1×3 px, 428 KB)

Physikerwelt added a comment.Jan 11 2024, 9:18 PM

... works now...

Jdlrobson moved this task from Backlog to Tracking on the Page-Previews board.Jan 17 2024, 12:02 AM
Jdlrobson edited projects, added Page-Previews (Tracking); removed Page-Previews.

Can this be closed now?

Physikerwelt closed this task as Resolved.Jan 17 2024, 6:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits