Page MenuHomePhabricator

PageTriage: URL shown for copyvio check leads to an error page: (HTTP status: 500)
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue :

  • Go to Special:NewPagesFeed
  • Filter by Potential Issues:Copyvio
  • Check the url that the Copyvio tag points to

What happens?: e.g. for the article 18th Game Developers Choice Awards the copyvio tag points to https://tools.wmflabs.org/copypatrol/en?filter=all&searchCriteria=page_exact&searchText=18th%20Game%20Developers%20Choice%20Awards&drafts=0&revision=1146389450
This then redirects to https://copypatrol.toolforge.org/en?filter=all&searchCriteria=page_exact&searchText=Danijel%20Džino&drafts=0&revision=1146569945 which returns a 500 Error

What should have happened instead?: The right link would be https://copypatrol.toolforge.org/en/?filter=all&filterPage=18th+Game+Developers+Choice+Awards&drafts=0&revision=1146389450, which gives the copyvio report

Related Objects

Event Timeline

Regression from this change by @MusikAnimal which removed the page_exact searchCriteria. Related line on PageTriage's side is ext.pageTriage.article.js:126 and it's hardcoded (so it's not as easy as changing a MediaWiki-namespace page).

Slightly related query: Is there a good reason for the redirection from tools.wmflabs.org/copypatrol to copypatrol.toolforge.org? Maybe PageTriage can take the reviewer directly to the toolforge tool.

Fairly sure this is a historical thing (i.e. back when Toolforge was Tool Labs and tools lived on a single domain (eldritch tome)). Since this isn't an on-wiki link (which would prompt the use of iw.toolforge.org), this could probably just be a direct link to copypatrol.toolforge.org.

If you're planning on changing the line I linked to above in PageTriage, might I also suggest making this customizable on a MediaWiki-namespace page or at least a configuration variable (like $wgPageTriageCopyvioReportLink or similar) as a step towards T50552? As of now, the link only points to the English Wikipedia version and, although CopyPatrol isn't running on all Wikipedias, it would be useful in case one of CopyPatrol's supported wikis get both PageTriage and CopyPatrol support (e.g. frwiki seems interested in PageTriage and is supported by CopyPatrol).

Change 908005 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/PageTriage@master] models/article.js: fix link to CopyPatrol and use wiki's content lang

https://gerrit.wikimedia.org/r/908005

I could have sworn that linked to https://copyvios.toolforge.org, not CopyPatrol! Anyway, the above patch should fix it and make it future-proof for when PageTriage expands to other language edition Wikipedias.

If you're planning on changing the line I linked to above in PageTriage, might I also suggest making this customizable on a MediaWiki-namespace page or at least a configuration variable (like $wgPageTriageCopyvioReportLink or similar) as a step towards T50552? As of now, the link only points to the English Wikipedia version and, although CopyPatrol isn't running on all Wikipedias, it would be useful in case one of CopyPatrol's supported wikis get both PageTriage and CopyPatrol support (e.g. frwiki seems interested in PageTriage and is supported by CopyPatrol).

As I understand it, the bot the powers CopyPatrol is also the one that tags revisions (see log), so there wouldn't be a situation where you'd link to anything other than CopyPatrol (even though I admit I thought it linked to a different tool entirely!). I do have it going by wgContentLanguage so that should work for other wikis too, because the link wouldn't be there in Special:NewPagesFeed in the first place if the wiki isn't supported by CopyPatrol.

As I understand it, the bot the powers CopyPatrol is also the one that tags revisions (see log), so there wouldn't be a situation where you'd link to anything other than CopyPatrol (even though I admit I thought it linked to a different tool entirely!)

Good point; I didn't think about that! Thank you for the patch! :D

Change 908005 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] models/article.js: fix link to CopyPatrol and use wiki's content lang

https://gerrit.wikimedia.org/r/908005

@MusikAnimal There is nothing flagged as a "copyvio" in Beta so I'll test it out on Thursday when it actually gets into English Wikipedia. Thanks!

T334274_CopyPatrol_CopyvioFilter.png (1,462×910 px, 149 KB)

@MusikAnimal Looks like it doesn't return the 500 error any more. There was one issue that I came across in Safari with no links w/ID showing when you hover over Copyvio like the first screenshot.

OS: macOS 13.3, Windows 11
Browsers: Chrome 112, Firefox 112, Edge 112, Safari 16.3
Skins: Vector 2022, 2010, Minerva, Timeless, Monobook
Test link: https://en.wikipedia.org/wiki/Special:NewPagesFeed

Copyvio- Good

T334274_FilterCopyvio_CopyPatrol1.png (2,672×1,302 px, 544 KB)

Copy Patrol- Good

T334274_FilterCopyvio_CopyPatrol2.png (3,341×704 px, 265 KB)

Safari- No link with ID# when hovering over Copyvio

T334274_FilterCopyvio_CopyPatrol_SafariMissing.png (1,777×1,081 px, 727 KB)

@MusikAnimal Since it seems like a Safari default behavior, I'll move this to Done as seen in https://phabricator.wikimedia.org/T334274#8812111. Thanks again!