Page MenuHomePhabricator

Personalized praise: design for skipping praiseworthy mentees
Closed, ResolvedPublic

Description

User story & summary:

As a Mentor, I want to skip a suggested praiseworthy mentee, so that I can stop seeing the suggestion if I decide I don't want to praise them.

Background & research:

This task is important because Mentors have suggested that it's necessary to make this feature useful. (Community feedback about Personalized Praise from EN, AR, BN, CS, ES, FR)

Design:

Figma designs

Skip a mentee 2 (1).png (429×448 px, 36 KB)

  • "Skip this mentee" button added to Personalize praise module on the Mentor dashboard.
  • When "Skip this mentee" is clicked, a dialog will open so the mentor can select why they want to skip that mentee.

Copy: Skip this mentee

Rejection reasons dialog:

Rejection dialog (1).png (323×446 px, 28 KB)

  • When the reason is submitted, the mentee is removed from the list of praise-worthy mentees, but can re-appear later if their activity matches the mentor's defined metrics and settings.

Copy:
(Optional) Why would you like to skip this mentee?
Skipping a mentee will remove them from the praise-worthy list temporarily. They can re-appear later if their following activity meets your preferred metrics.

  • I've already sent praise to this mentee
  • I don't think this mentee is praise-worthy
  • I don't want to send praise now
  • Other / I'd rather not say
Acceptance Criteria:

Given there are "praiseworthy mentees" listed on a Mentor Dashboard,
When the Mentor wants to dismiss the suggestion,
Then the Mentor can dismiss the suggestion using the "Skip this mentee" button.

  • When "Skip this mentee" is selected and reasons are submitted,
  • Then that mentee is removed from the praiseworthy mentee list for a period of time.

Event Timeline

KStoller-WMF added a subscriber: JFernandez-WMF.

@JFernandez-WMF - here's the task to cover the engineering effort associated with T332219: Personalized praise: design for skipping or "checking off" praiseworthy mentees .

Can you update the attached images and Figma link to make sure they reflect the final copy

Checked in with Rita today and we decided on an initial design. I'll comment here and also update the ticket:

  • As we agreed, we will go ahead with v1, this means the action of skipping a mentee will be temporary and not permanent.
  • We will change the button copy to "Skip this mentee".
  • If possible, we will have rejection reasons as they can be useful for filters. Submitting a rejection reason will be optional and the dialog will explain that the action is temporary and the mentee may be suggested for appreciation again (therefore we will not need the tooltip on hover).

Design

New button on the moduleDialog with rejection reasons
Skip a mentee.png (429×448 px, 37 KB)
Rejection dialog.png (323×446 px, 29 KB)

How does this sound? @Urbanecm_WMF / @KStoller-WMF feel free to voice any thoughts 😸

@JFernandez-WMF This sounds good to me. My only feedback is that we've decided to stick with the "praise" language over "appreciation" - T326961.

Neither is quite perfect, but at least "praise" is shorter and in other languages they can localize to whatever word they find most fitting.

That is true, thank you @KStoller-WMF! I edited the task description with the final copy.

Hi @JFernandez-WMF and @KStoller-WMF, Thanks for the ping and the designs! They look good to me. I assume we only need to record the feedback from the mentor in instrumentation, and otherwise nothing needs to happen on it?

As discussed during the coordination meeting, a skip mentee will return to the list after 8 days. The rejection design should indicate it.

I assume we only need to record the feedback from the mentor in instrumentation, and otherwise nothing needs to happen on it?

Correct.

As discussed during the coordination meeting, a skip mentee will return to the list after 8 days. The rejection design should indicate it.

Since we plan to include this metrics in the actual design, I suggest we use 10 days so it doesn't feel quite as arbitrary. Does that sound OK?

Change 908359 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] [WIP] Personalized praise: Let mentors to skip suggestions

https://gerrit.wikimedia.org/r/908359

Change 908520 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[schemas/event/secondary@master] Personalized praise: Add instrumentation for skipping suggestions

https://gerrit.wikimedia.org/r/908520

I updated the designs specifying the 10-day period that we set for now

Urbanecm_WMF changed the task status from Open to In Progress.Apr 14 2023, 3:33 PM

Moving to In Progress, as I'm currently working on engineering the feature.

Change 908520 merged by jenkins-bot:

[schemas/event/secondary@master] Personalized praise: Add instrumentation for skipping suggestions

https://gerrit.wikimedia.org/r/908520

Change 908359 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Personalized praise: Let mentors to skip suggestions

https://gerrit.wikimedia.org/r/908359

Since we plan to include this metrics in the actual design, I suggest we use 10 days so it doesn't feel quite as arbitrary. Does that sound OK?

Of course!

Change 914426 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.6] Personalized praise: Let mentors to skip suggestions

https://gerrit.wikimedia.org/r/914426

Urbanecm_WMF changed the task status from In Progress to Open.May 2 2023, 10:50 PM
Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 914426 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.41.0-wmf.6] Personalized praise: Let mentors to skip suggestions

https://gerrit.wikimedia.org/r/914426

Mentioned in SAL (#wikimedia-operations) [2023-05-03T08:32:37Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:914426|Personalized praise: Let mentors to skip suggestions (T334300)]]

Mentioned in SAL (#wikimedia-operations) [2023-05-03T09:00:17Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:914426|Personalized praise: Let mentors to skip suggestions (T334300)]] (duration: 27m 39s)

Mentioned in SAL (#wikimedia-operations) [2023-05-03T09:11:42Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:914426|Personalized praise: Let mentors to skip suggestions (T334300)]]

Mentioned in SAL (#wikimedia-operations) [2023-05-03T09:11:48Z] <urbanecm@deploy1002> sync-world aborted: Backport for [[gerrit:914426|Personalized praise: Let mentors to skip suggestions (T334300)]] (duration: 00m 06s)

Etonkovidova subscribed.

Overall, looks good:

skip three mentees  2023-05-03 at 8.04.33 AM.png (1×1 px, 116 KB)
reasons skipping mentees 2023-05-03 at 8.20.04 AM.png (806×1 px, 136 KB)

For Design review - some minor observations:

(1) "Las edited" metric is added - I did not find it in Figma design.

skip one mentee  2023-05-01 at 4.24.30 PM.png (1×948 px, 136 KB)

(2) The wording for growthexperiments-mentor-dashboard-personalized-praise-intro "Positive messages from experienced users and mentors increases editor retention." Should increase be used not increases?
(3) Selecting 2 weeks would display 15 days.
skip one mentee 2023-05-02 at 8.39.07 AM.png (1×2 px, 268 KB)

(4) "Metric" should be bolded according to the mockup.

Change 916521 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] Personalized praise: Minor improvements

https://gerrit.wikimedia.org/r/916521

Thanks for the review @Etonkovidova! (2)-(4) are definitely bugs, I uploaded a patch fixing those things. Ad (1), as far as I remember, it was agreed to use the same scorecards as present in the new Impact module. Happy to change that if we (re)decide in a different way though.

Thanks for the review @Etonkovidova! (2)-(4) are definitely bugs, I uploaded a patch fixing those things. Ad (1), as far as I remember, it was agreed to use the same scorecards as present in the new Impact module. Happy to change that if we (re)decide in a different way though.

Thanks, @Urbanecm_WMF! Re "to use the same scorecards as present in the new Impact module" - yes, I thought so too; I added it to my observations to double-check, just in case.

Thank you @Etonkovidova and @Urbanecm_WMF! Regarding the scorecards, what we would be re-using from the Impact Module is the design, but not necessarily the information. The personalized praise module should have the 3 scorecards (Total edits, Thanks received, and Longest streak), while the Impact module should keep the four scorecards. Hope this helps. Martin, feel free to reach out with questions!

Change 916521 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Personalized praise: Minor improvements

https://gerrit.wikimedia.org/r/916521

We plan to change the scorecard layout in this task T333036: Positive Reinforcement: Personalized praise design improvements for revert data .
So, I think it's OK to resolve this task for now. Thanks!