Steps to replicate the issue (include links if applicable):
- Create a Poll on Special:SecurePoll
- Vote
- Check List
- Click on Details of any of the voters
What happens?:
You get an SQL Error
What should have happened instead?:
Getting a normal list
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix SQL Error on Voter Details Page | mediawiki/extensions/SecurePoll | master | +2 -2 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| In Progress | • Niharika | T324492 Temporary accounts - MVP | |||
| Open | None | T326816 Update features for IP Masking | |||
| Open | Tchanders | T326869 Update TSP-owned products that may be affected by IP Masking | |||
| Resolved | • AGueyte | T331750 Investigate: Update SecurePoll for IP Masking | |||
| Resolved | BUG REPORT | • AGueyte | T334490 SecurePoll Vote Details returns SQL Error |
Event Timeline
Comment Actions
Change 907913 had a related patch set uploaded (by AGueyte; author: AGueyte):
[mediawiki/extensions/SecurePoll@master] Fix SQL Error on Voter Details Page
Comment Actions
Change 907913 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Fix SQL Error on Voter Details Page
Comment Actions
@AGueyte One issue that I came across so far when creating a poll and clicking on the details of the voter is not an SQL error anymore but a deprecate on line 130 as seen in the screenshot below.
OS: macOS 13.2
Browser: Chrome 112
Skins: Vector 2010
Local- SQLite
Beta- MySQL
Comment Actions
I think it's a fair warning from htmlspecialchars() as the vote value might not always include special chars.
I'm happy to leave it as is.
Comment Actions
@AGueyte Ok sounds good! I did notice one more minor possible issue under the Minerva skin as seen below for "User agent". I'm not sure if you want a separate ticket or if this is fine.
Minerva Skin- no matter the Zoom level, it's still 2 lines for "User agent" field unlike the rest of the skins, it's just one line.
Other Skins
Comment Actions
Sounds good to me! I'll move this to Done as stated in https://phabricator.wikimedia.org/T334490#8786750. Thanks!