Page MenuHomePhabricator

SecurePoll Vote Details returns SQL Error
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT


Steps to replicate the issue (include links if applicable):

  • Create a Poll on Special:SecurePoll
  • Vote
  • Check List
  • Click on Details of any of the voters

What happens?:
You get an SQL Error

Screenshot 2023-04-11 at 11.40.31 AM.png (1×2 px, 628 KB)

What should have happened instead?:
Getting a normal list

Screenshot 2023-04-11 at 11.50.09 AM.png (1×2 px, 176 KB)

Event Timeline

AGueyte created this task.
AGueyte set Final Story Points to 1.

Change 907913 had a related patch set uploaded (by AGueyte; author: AGueyte):

[mediawiki/extensions/SecurePoll@master] Fix SQL Error on Voter Details Page

Change 907913 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Fix SQL Error on Voter Details Page

@AGueyte One issue that I came across so far when creating a poll and clicking on the details of the voter is not an SQL error anymore but a deprecate on line 130 as seen in the screenshot below.

OS: macOS 13.2
Browser: Chrome 112
Skins: Vector 2010

Local- SQLite

T334490_SecurePoll_Deprecate.png (1×3 px, 257 KB)

Beta- MySQL

T334490_SecurePoll_VotersDetail.png (979×3 px, 201 KB)

Thank you @George, I will investigate this and create a ticket if necessary!

AGueyte set the point value for this task to 1.Apr 13 2023, 5:17 PM

I think it's a fair warning from htmlspecialchars() as the vote value might not always include special chars.
I'm happy to leave it as is.

@AGueyte Ok sounds good! I did notice one more minor possible issue under the Minerva skin as seen below for "User agent". I'm not sure if you want a separate ticket or if this is fine.

Minerva Skin- no matter the Zoom level, it's still 2 lines for "User agent" field unlike the rest of the skins, it's just one line.

T334421_SecurePoll_Details_MinervaSpacing.png (1×1 px, 145 KB)

Other Skins

T334421_SecurePoll_Details_OtherSkinsSpacing.png (1×1 px, 164 KB)

Not an issue for me! This looks fine to me and is expected.