Page MenuHomePhabricator
Create Task
Maniphest T334498

Search Preview should be closed when Advanced search is clicked
Open, Needs TriagePublic
Actions

Description

Split from T323843 (based on @SimoneThisDot comment

When Advanced search is enabled, clicking it should close the search preview (currently clicking the advanced search does not close the search preview).

Related Objects

Event Timeline

Etonkovidova created this task.Apr 11 2023, 5:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 11 2023, 5:52 PM
Etonkovidova mentioned this in T323843: [S] Tablet: Improve the search layout and search preview widths on tablets.Apr 11 2023, 5:56 PM
MarkTraceur subscribed.Apr 24 2023, 5:02 PM

Note this would probably be fairly difficult per an initial investigation, as a result I believe the team probably won't pursue it at this time.

MarkTraceur added a comment.Apr 24 2023, 5:03 PM

More from @SimoneThisDot : "Advanced search uses OOUI components that stop the propagation of the click events, making it hard to listen to that event on other extensions. The only way to fix it is by coupling the two extensions."

AUgolnikova-WMF moved this task from Triage to SDAW Search Improvements on the Structured-Data-Backlog board.Apr 24 2023, 5:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL