Page MenuHomePhabricator

PageTriage should have the ability to remove the copyvio tag (via API)
Closed, ResolvedPublicFeature

Description

Feature summary: The copypatrol tool allows editors to check and fix copyright problems. But the message about the problem being fixed has no way of getting to PageTriage. If the pagetriagetagcopyvio API allowed untagging an article for a copyvio issue, then copypatrol would be able to call it when a page's copyvio problem has been fixed.

Benefits : Reviewers will not be bothered by copyvio tags where the problem has been taken care of.

Details

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

This is a great idea. I'll note that currently, we don't have credentials for the bot that powers CopyPatrol, but after T333724 we will. Thus I'm adding it as a subtask.

JJMC89 subscribed.

Please open a CopyPatrol feature request after the PageTriage API support for this is in production.

How do we do this in the PageTriage API? Setting a new param called untag=1, when we want the copyvio tag to be removed? This is the way it is done in the watch API (https://www.mediawiki.org/wiki/API:Watch#API_documentation).

Would definitely want to reuse the pagetriagetagcopyvio API rather than making a new one.

Currently the only parameter it takes is revid.

Would a better approach be to add an &action=tag / &action=untag, and have it default to tag when receiving null input for backwards compatibility?

https://en.wikipedia.org/wiki/Special:ApiSandbox

image.png (1,477×584 px, 46 KB)

Change 981421 had a related patch set uploaded (by MPGuy2824; author: MPGuy2824):

[mediawiki/extensions/PageTriage@master] [WIP] Allow removal of copyvio tag via API

https://gerrit.wikimedia.org/r/981421

  1. How does the pagetriagetagcopyvio API work? On a page with multiple revisions, I tried tagging the top revision and bottom revision as copyright violations, and I could not get PageTriage to display the "copyvio" tag. Then I figured out to set $wgPageTriageEnableCopyvio = true; but was getting inconsistent results. I will probably have to go read the code to figure out how this works. There may be a bug here.
  1. Because this API takes a revision ID instead of a page ID, it may not make sense to allow unmarking a revision as a copyright violation. Because even if a future revision removes the copyvio, the tagged revision still contains copyvio. Perhaps we need a completely different approach, such as tagging page IDs instead.
  1. How does the pagetriagetagcopyvio API work? On a page with multiple revisions, I tried tagging the top revision and bottom revision as copyright violations, and I could not get PageTriage to display the "copyvio" tag. Then I figured out to set $wgPageTriageEnableCopyvio = true; but was getting inconsistent results. I will probably have to go read the code to figure out how this works. There may be a bug here.

Huh, I do see this as well, I will poke at this sleeping dragon, hopefully, if thing go well, it will not transfigure into a can of worms.

  1. Because this API takes a revision ID instead of a page ID, it may not make sense to allow unmarking a revision as a copyright violation. Because even if a future revision removes the copyvio, the tagged revision still contains copyvio. Perhaps we need a completely different approach, such as tagging page IDs instead.

I don't think that is the intended usecase, here (and I think "mark as copyvio" is a misnomer, it should ideally be "mark as probably having a copyvio which shows up in the latest version of the page"). We can/should mark a page id as not a copyvio if it has been dealt with on the latest version of the page and revdelled. (Similar to how we can mark a specific revision of a page as fixed on copypatrol).

Change 981421 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Allow removal of copyvio tag via API

https://gerrit.wikimedia.org/r/981421