Page MenuHomePhabricator
Create Task
Maniphest T334551

action=help&toc=1: Caught exception of type TypeError
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Steps to replicate the issue:

Make an action=help API call with toc=1 (e.g. this).

What happens?:

{
    "error": {
        "code": "internal_api_error_TypeError",
        "info": "[8e4c60be-8654-49b2-b4c7-c63150d49476] Caught exception of type TypeError",
        "errorclass": "TypeError"
    },
    "servedby": "mw2418"
}

What should have happened instead?:
MediaWiki should have returned the HTML content with TOC added.

TypeError: Argument 5 passed to Wikimedia\Parsoid\Core\SectionMetadata::__construct() must be of the type string, bool given, called in /srv/mediawiki/php-1.41.0-wmf.4/vendor/wikimedia/parsoid/src/Core/SectionMetadata.php

Error
normalized_message
[{reqId}] {exception_url}   TypeError: Argument 5 passed to Wikimedia\Parsoid\Core\SectionMetadata::__construct() must be of the type string, bool given, called in /srv/mediawiki/php-1.41.0-wmf.4/vendor/wikimedia/parsoid/src/Core/SectionMetadata.php on line 303
exception.trace
from /srv/mediawiki/php-1.41.0-wmf.4/vendor/wikimedia/parsoid/src/Core/SectionMetadata.php(157)
#0 /srv/mediawiki/php-1.41.0-wmf.4/vendor/wikimedia/parsoid/src/Core/SectionMetadata.php(303): Wikimedia\Parsoid\Core\SectionMetadata->__construct(integer, integer, string, string, boolean, NULL, NULL, string, string, NULL)
#1 /srv/mediawiki/php-1.41.0-wmf.4/vendor/wikimedia/parsoid/src/Core/TOCData.php(200): Wikimedia\Parsoid\Core\SectionMetadata::fromLegacy(array)
#2 [internal function]: Wikimedia\Parsoid\Core\TOCData::Wikimedia\Parsoid\Core\{closure}(array)
#3 /srv/mediawiki/php-1.41.0-wmf.4/vendor/wikimedia/parsoid/src/Core/TOCData.php(199): array_map(Closure, array)
#4 /srv/mediawiki/php-1.41.0-wmf.4/includes/api/ApiHelp.php(189): Wikimedia\Parsoid\Core\TOCData::fromLegacy(array)
#5 /srv/mediawiki/php-1.41.0-wmf.4/includes/api/ApiHelp.php(77): ApiHelp::getHelp(DerivativeContext, array, array)
#6 /srv/mediawiki/php-1.41.0-wmf.4/includes/api/ApiMain.php(1908): ApiHelp->execute()
#7 /srv/mediawiki/php-1.41.0-wmf.4/includes/api/ApiMain.php(884): ApiMain->executeAction()
#8 /srv/mediawiki/php-1.41.0-wmf.4/includes/api/ApiMain.php(855): ApiMain->executeActionWithErrorHandling()
#9 /srv/mediawiki/php-1.41.0-wmf.4/api.php(91): ApiMain->execute()
#10 /srv/mediawiki/php-1.41.0-wmf.4/api.php(46): wfApiMain()
#11 /srv/mediawiki/w/api.php(3): require(string)
#12 {main}

Details

MediaWiki Version
1.41.0-wmf.4
Request URL
https://www.mediawiki.org/w/api.php?action=help&modules=*&toc=*
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix breakages generating TOC for API Help pagesmediawiki/coremaster+13 -10
Ensure ApiHelp correctly types values in TOCData objectsmediawiki/corewmf/1.41.0-wmf.4+4 -4
Ensure ApiHelp correctly types values in TOCData objectsmediawiki/corewmf/1.41.0-wmf.3+4 -4
Ensure ApiHelp correctly types values in TOCData objectsmediawiki/coremaster+4 -4
Customize query in gerrit

Related Objects

Event Timeline

NguoiDungKhongDinhDanh created this task.Apr 12 2023, 5:41 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 12 2023, 5:41 AM
Aklapper changed the subtype of this task from "Bug Report" to "Production Error".Apr 12 2023, 7:48 AM
Aklapper edited projects, added Parsoid, Wikimedia-production-error; removed MediaWiki-Action-API.
Aklapper set Request URL to https://www.mediawiki.org/w/api.php?action=help&modules=*&toc=*.
Aklapper updated the task description. (Show Details)
Aklapper set Release Version to 1.41.0-wmf.4.
hashar triaged this task as Unbreak Now! priority.Apr 12 2023, 10:12 AM
hashar updated the task description. (Show Details)
hashar added a parent task: T330210: 1.41.0-wmf.4 deployment blockers.
hashar mentioned this in T330210: 1.41.0-wmf.4 deployment blockers.
hashar added a project: Content-Transform-Team.
hashar subscribed.

I have flagged it as a train blocker since it is apparently new to 1.41.0-wmf.4

Zabe subscribed.Apr 12 2023, 10:18 AM

I can reproduce this on enwiki (f3b41f5d-9ad3-4ced-8b6d-4a39762dd365) which is on 1.41.0-wmf.3.

ssastry subscribed.Apr 12 2023, 3:08 PM

This is not a new failure -- there is no new code from Parsoid on this train and as Zabe notes, this is present on the previous train as well. But, in any case, this is probably something in core (ApiHelp.php) and we should be able to fix it there to conform to the signature. Something that probably slipped past us when we were working on TOC changes in Feb and March.

But, unless there is a big spike of these errors, I don't think this is a UBN.

ssastry added a comment.Apr 12 2023, 3:22 PM

This broke in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/885871 and so has been live since 1.40.0-wmf.23

gerritbot added a comment.Apr 12 2023, 3:27 PM

Change 908259 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/core@master] Ensure ApiHelp correctly types values in TOCData objects

https://gerrit.wikimedia.org/r/908259

gerritbot added a project: Patch-For-Review.Apr 12 2023, 3:27 PM
hashar added a comment.Apr 12 2023, 4:52 PM

I guess we can still move forward with the train and handle the backport this week when the patch got reviewed/merged. Given it is an old issue with few occurrences, it might not be worth blocking the train on it.

gerritbot added a comment.Apr 12 2023, 6:16 PM

Change 908259 merged by jenkins-bot:

[mediawiki/core@master] Ensure ApiHelp correctly types values in TOCData objects

https://gerrit.wikimedia.org/r/908259

ssastry lowered the priority of this task from Unbreak Now! to Medium.Apr 12 2023, 6:24 PM

I am going to be bold and mark this *not UBN*.

ssastry added a comment.Apr 12 2023, 6:25 PM

Oh, the patch is merged now anyway.

ssastry removed a parent task: T330210: 1.41.0-wmf.4 deployment blockers.Apr 12 2023, 6:25 PM
ssastry edited projects, added Content-Transform-Team-WIP, MediaWiki-Action-API; removed Content-Transform-Team, Parsoid.
Maintenance_bot removed a project: Patch-For-Review.Apr 12 2023, 6:30 PM
gerritbot added a comment.Apr 12 2023, 6:42 PM

Change 908289 had a related patch set uploaded (by Jforrester; author: Subramanya Sastry):

[mediawiki/core@wmf/1.41.0-wmf.4] Ensure ApiHelp correctly types values in TOCData objects

https://gerrit.wikimedia.org/r/908289

gerritbot added a project: Patch-For-Review.Apr 12 2023, 6:42 PM

Change 908290 had a related patch set uploaded (by Jforrester; author: Subramanya Sastry):

[mediawiki/core@wmf/1.41.0-wmf.3] Ensure ApiHelp correctly types values in TOCData objects

https://gerrit.wikimedia.org/r/908290

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.5; 2023-04-17).Apr 12 2023, 7:00 PM
gerritbot added a comment.Apr 12 2023, 7:28 PM

Change 908290 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.3] Ensure ApiHelp correctly types values in TOCData objects

https://gerrit.wikimedia.org/r/908290

gerritbot added a comment.Apr 12 2023, 7:28 PM

Change 908289 merged by jenkins-bot:

[mediawiki/core@wmf/1.41.0-wmf.4] Ensure ApiHelp correctly types values in TOCData objects

https://gerrit.wikimedia.org/r/908289

Stashbot added a comment.Apr 12 2023, 7:30 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-12T19:30:51Z] <zabe@deploy2002> Started scap: Backport for [[gerrit:908291|composer.json: Explicitly pin psr/http-message to 1.0.1 (T333993)]], [[gerrit:908290|Ensure ApiHelp correctly types values in TOCData objects (T334551)]], [[gerrit:908289|Ensure ApiHelp correctly types values in TOCData objects (T334551)]]

Stashbot mentioned this in T333993: Explicitly pin psr/http-message to 1.0.1 in composer.json.Apr 12 2023, 7:30 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 12 2023, 7:30 PM
Stashbot added a comment.Apr 12 2023, 7:32 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-12T19:32:12Z] <zabe@deploy2002> jforrester and zabe: Backport for [[gerrit:908291|composer.json: Explicitly pin psr/http-message to 1.0.1 (T333993)]], [[gerrit:908290|Ensure ApiHelp correctly types values in TOCData objects (T334551)]], [[gerrit:908289|Ensure ApiHelp correctly types values in TOCData objects (T334551)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.

Zabe added a comment.Apr 12 2023, 7:35 PM

This now causes the following error, reverting fix on prod for now.

[977b6475-f293-46e5-b175-d5a6efb7d810] /w/api.php?action=help&modules=main&toc=1   Error: Cannot unpack array with string keys
	
from /srv/mediawiki/php-1.41.0-wmf.4/vendor/wikimedia/parsoid/src/Core/TOCData.php(204)
#0 /srv/mediawiki/php-1.41.0-wmf.4/includes/api/ApiHelp.php(189): Wikimedia\Parsoid\Core\TOCData::fromLegacy(array)
#1 /srv/mediawiki/php-1.41.0-wmf.4/includes/api/ApiHelp.php(77): ApiHelp::getHelp(DerivativeContext, array, array)
#2 /srv/mediawiki/php-1.41.0-wmf.4/includes/api/ApiMain.php(1908): ApiHelp->execute()
#3 /srv/mediawiki/php-1.41.0-wmf.4/includes/api/ApiMain.php(884): ApiMain->executeAction()
#4 /srv/mediawiki/php-1.41.0-wmf.4/includes/api/ApiMain.php(855): ApiMain->executeActionWithErrorHandling()
#5 /srv/mediawiki/php-1.41.0-wmf.4/api.php(91): ApiMain->execute()
#6 /srv/mediawiki/php-1.41.0-wmf.4/api.php(46): wfApiMain()
#7 /srv/mediawiki/w/api.php(3): require(string)
#8 {main}
ssastry added a comment.Apr 12 2023, 7:37 PM

Okay, looks like there is more digging to be done here.

ssastry added a comment.Apr 12 2023, 7:55 PM

Testing locally, even if I revert Scott's patch, looks like the TOC on the API help page has been broken from other TOC changes we had been landing since last year. Anyway, additional patches coming.

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.4; 2023-04-10); removed MW-1.41-notes (1.41.0-wmf.5; 2023-04-17).Apr 12 2023, 8:00 PM
ssastry added a comment.Apr 12 2023, 8:18 PM

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/885871 also caused the new breakage. When I fix that I find that the TOC is empty which was caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/862391. Fix coming.

gerritbot added a comment.Apr 12 2023, 8:34 PM

Change 908348 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/core@master] Fix breakages generating TOC for API Help pages

https://gerrit.wikimedia.org/r/908348

gerritbot added a project: Patch-For-Review.Apr 12 2023, 8:34 PM
thcipriani moved this task from Untriaged to Apr 2023 on the Wikimedia-production-error board.Apr 13 2023, 3:41 PM
ssastry claimed this task.Apr 13 2023, 4:00 PM
ssastry moved this task from Backlog to Code Review on the Content-Transform-Team-WIP board.
• matmarex subscribed.Apr 17 2023, 5:03 PM
gerritbot added a comment.Apr 17 2023, 5:22 PM

Change 908348 merged by jenkins-bot:

[mediawiki/core@master] Fix breakages generating TOC for API Help pages

https://gerrit.wikimedia.org/r/908348

Maintenance_bot removed a project: Patch-For-Review.Apr 17 2023, 5:29 PM
• matmarex closed this task as Resolved.Apr 17 2023, 6:33 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.9; 2023-05-15); removed MW-1.41-notes (1.41.0-wmf.4; 2023-04-10).May 15 2023, 2:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits