Page MenuHomePhabricator

Links cannot be clicked while logged in on English Wikipedia at 1.41.0-wmf.4
Closed, ResolvedPublicBUG REPORT

Description

Shortly after rolling the train to all wikis, users noticed that links on English Wikipedia weren't clickable while logged in.

12:35 <MatmaRex> i can't click on anything on any page while logged in
12:35 <MatmaRex> not sure if it's just me
12:35 <brennen> MatmaRex: yeah, something's up in general, 139 php restart failures
12:36 <MatmaRex> hmm, maybe it's a temporary issue. like incompatible versions of HTML and CSS being served temporarily or something
12:36 <dancy> Hrm
12:37 <brennen> https://phabricator.wikimedia.org/P46678
12:38 <rzl> I see the same as MatmaRex -- looks like there's a .vector-menu-checkbox that has width: 100% and height: 100% and is covering the page

There was some confusion as to whether this was caused by an error during the deployment process, but I rolled forward and tested once that was confirmed. Bug still present, and rzl's assessment appears correct.

Steps to replicate the issue (include links if applicable):

  1. Log in.
  2. Load a page, attempt to click a link.

What happens?:

Nothing.

What should have happened instead?:

Links should work.

Other information (browser name/version, screenshots, etc.):

I tested in Firefox 112.0 on Debian Stable. My skin is set to Vector (2022).

Screenshot:

2023-04-13-13:57:03.png (1×1 px, 404 KB)

Event Timeline

brennen triaged this task as Unbreak Now! priority.Apr 13 2023, 8:09 PM
brennen added a project: Web-Team-Backlog.
brennen updated the task description. (Show Details)

I got this problem too on the French Wikipedia between 18h35 and 18h41 UTC when viewing https://fr.wikipedia.org/wiki/Syst%C3%A8me_Taffy. Other French users did not have the problem while I was having it. Problem fixed itself after a few minutes and several restarts of my browser (Firefox on Windows 11).

Was unable to reproduce on mwdebug2001; after discussion with @Jdlrobson it seems likely this was a transient issue of old assets + new PHP code. We've rolled to all wikis again and will leave this open for a bit to see if it crops back up again, but I can't current repro.

brennen claimed this task.

No reports yet. Optimistically resolving.

So this is what I believe happened:

We added a new rule in 6e8a98ca8 #vector-toc-collapsed-checkbox { display: none; }. What happened here is users impacted by the bug were not loading the new CSS but were getting the new HTML. This can happen in the 5 minutes following a train deploy. cc @Jdrewniak

I think that isn't quite right in all details—from a screenshot I took, you can see that I did have the rule #vector-toc-collapsed-checkbox { display: none; }, but it was being overridden by :not(:checked) > .vector-menu-checkbox { display: block; }. But I agree that it seems likely I was getting some mix of old and new CSS.

I think that isn't quite right in all details—from a screenshot I took, you can see that I did have the rule #vector-toc-collapsed-checkbox { display: none; }, but it was being overridden by :not(:checked) > .vector-menu-checkbox { display: block; }. But I agree that it seems likely I was getting some mix of old and new CSS.

I'm not seeing the display none rule in the screenshot. The :not selector should be overriden by the ID selector due to CSS specificity value.