Page MenuHomePhabricator

Global preference override checkbox is not indented in mobile
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Go to Special:GlobalPreferences and set a global preference.
  • Go to Special:Preferences in mobile mode and navigate to the preference you have set globally.

What happens?:
A new checkbox appears that lets you override that global preference for that Wiki. It is not correctly indented.

Screen Shot 2023-04-13 at 19.27.24.png (117×773 px, 16 KB)

What should have happened instead?:
Indentation should be the same as in the Desktop version.

Screen Shot 2023-04-13 at 19.26.39.png (71×464 px, 12 KB)

Event Timeline

Change 920339 had a related patch set uploaded (by Func; author: Func):

[mediawiki/core@master] Implement HTMLToggleSwitchField for mobile layout of preferences

https://gerrit.wikimedia.org/r/920339

Change 920339 merged by jenkins-bot:

[mediawiki/core@master] Implement HTMLToggleSwitchField for mobile layout of preferences

https://gerrit.wikimedia.org/r/920339

Test wiki on Patch demo by JSherman (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/34de885f3a/w/