Page MenuHomePhabricator
Create Task
Maniphest T334713

Should Special:Block perform automatic lookups of IP addresses for temporary users?
Closed, ResolvedPublic
Actions

Assigned To
Func
Authored By
Tchanders
Apr 14 2023, 9:05 AM
Tags
Referenced Files
F36963138: image (2).png
Apr 26 2023, 1:09 AM
Restricted File
Apr 17 2023, 5:13 PM
F36954604: image.png
Apr 17 2023, 5:11 PM
F36954601: image.png
Apr 17 2023, 5:11 PM
F36954599: image.png
Apr 17 2023, 5:11 PM
F36954597: image.png
Apr 17 2023, 5:11 PM
Subscribers
Aklapper
Dreamy_Jazz
• Niharika
• Prtksxna
Tchanders

Description

In most places in the UI, if someone wants to look up IP addresses for a temporary user, they will click on a "Show IP" button. Their lookup is logged.

However, on Special:Block, simply selecting a temporary user in the target field, or visiting Special:Block/<tempuser>, will perform an IP address lookup and log their activity.

While it is a smooth user experience to see IP addresses without having to click a lot, is it a concern that a user's activity might be logged in ways they didn't anticipate? (E.g. clicking on a temp user's block link by accident, or blocking a temp user without needing to look up their IP.)

Details

SubjectRepoBranchLines +/-
SpecialBlock.js: Switch to plain user input with "show ip" buttonmediawiki/extensions/CheckUsermaster+53 -56
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Apr 14 2023, 9:05 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 14 2023, 9:05 AM
gerritbot added a comment.Apr 16 2023, 3:22 PM

Change 904602 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/CheckUser@master] SpecialBlock.js: Switch to plain user input with "show ip" button

https://gerrit.wikimedia.org/r/904602

gerritbot added a project: Patch-For-Review.Apr 16 2023, 3:22 PM
• Prtksxna added a comment.EditedApr 17 2023, 5:11 PM
Selecting a userWhen the user has no IP dataUser has IP dataShowing IPs
image.png (1×2 px, 335 KB)
image.png (1×2 px, 334 KB)
{F36954606}
image.png (1×2 px, 341 KB)

Discussed with @Tchanders how we could show whether or not data is available, and add the button for users to click to be able to show all IPs.

Dreamy_Jazz moved this task from General / Unsorted to Patches for review on the CheckUser board.Apr 22 2023, 10:03 AM
Dreamy_Jazz moved this task from Patches for review to Temporary account IP reveal on the CheckUser board.
• Prtksxna mentioned this in T335253: Special:Block - Remove "See more" link that currently shows up when there are too many IPs.Apr 24 2023, 1:52 AM
Tchanders added a parent task: T300294: [Epic] Temporary account block workflow.Apr 25 2023, 5:54 PM
Tchanders mentioned this in T334870: Restore user input widget on Special:Block.Apr 25 2023, 5:56 PM
Dreamy_Jazz added a comment.Apr 25 2023, 6:34 PM

@Prtksxna hi. It seems the third image in the post above isn't attached to the task and so I can't see it. Would it be possible to attach it to the task so I can see. Thanks.

• Prtksxna added a comment.Apr 26 2023, 1:09 AM

Sorry @Dreamy_Jazz! Not sure how to attach an image to task so uploading again and hoping it works

image (2).png (1×2 px, 335 KB)

Dreamy_Jazz added a comment.EditedApr 27 2023, 2:58 PM

Thanks. It has.

Tchanders edited projects, added Anti-Harassment (AHaT Sprint 29: The Ikseongwan); removed Anti-Harassment.May 4 2023, 2:46 AM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 29: The Ikseongwan) board.May 4 2023, 2:50 AM
Tchanders reassigned this task from • Prtksxna to Func.May 4 2023, 4:52 PM
Tchanders moved this task from Code Review 🔍 to Done Q2 2022-2023 on the Anti-Harassment (AHaT Sprint 29: The Ikseongwan) board.

Bypassing QA - this can be tested via T335253: Special:Block - Remove "See more" link that currently shows up when there are too many IPs.

gerritbot added a comment.May 4 2023, 5:06 PM

Change 904602 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] SpecialBlock.js: Switch to plain user input with "show ip" button

https://gerrit.wikimedia.org/r/904602

Maintenance_bot removed a project: Patch-For-Review.May 4 2023, 5:11 PM
Dreamy_Jazz added a comment.EditedMay 4 2023, 5:58 PM

This seems to have re-introduced T332136 by not automatically showing the button if the username is pre-filled. Filed as T335996.

Dreamy_Jazz mentioned this in T335996: "Show IP" button not shown on Special:Block if form has username pre-filled.May 4 2023, 6:02 PM
Dreamy_Jazz added a subtask: T335996: "Show IP" button not shown on Special:Block if form has username pre-filled.
Dreamy_Jazz closed subtask T335996: "Show IP" button not shown on Special:Block if form has username pre-filled as Resolved.May 4 2023, 10:14 PM
Tchanders closed this task as Resolved.May 5 2023, 5:20 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 10:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL