Page MenuHomePhabricator

generate_family_file_tests sometimes fails with TestGenerateFamilyFiles.test_attributes_after_run
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue:

Modify FamilyTestGenerator in generate_family_file_tests that ii wiki is always used:

def getapis(self):
    """Only load up to additional ten different wikis randomly."""
    save = self.langs
    self.langs = sample(save, min(len(save), 9))
    for k in save:
        if k['prefix'] == 'ii':
            self.langs.append(k)
    self.prefixes = [item['prefix'] for item in self.langs]
    super().getapis()
    self.langs = save

What happens?:

Test always fails:

  test_attributes_after_run (__main__.TestGenerateFamilyFiles.test_attributes_after_run) (test='Test element counts')
Test FamilyFileGenerator attributes after run(). ... FAIL
 16.152s
======================================================================
FAIL: test_attributes_after_run (__main__.TestGenerateFamilyFiles.test_attributes_after_run) (test='Test element counts')
Test FamilyFileGenerator attributes after run().
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\pwb\GIT\core\tests\generate_family_file_tests.py", line 82, in test_attributes_after_run
    self.assertCountEqual(gen.prefixes, gen.wikis)
AssertionError: Element counts were not equal:
First has 1, Second has 0:  'ii'

----------------------------------------------------------------------
Ran 1 test in 17.073s

FAILED (failures=1)

https://integration.wikimedia.org/ci/job/pywikibot-core-tox-deeptest-py36-docker/2353/console

Other information
The same problem occurs with kr-wiki: str object has no description

Event Timeline

Xqt changed the task status from Open to In Progress.Apr 14 2023, 11:16 AM
Xqt claimed this task.

Change 908829 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [tests] Remove obsolete sites from TestGenerateFamilyFiles test

https://gerrit.wikimedia.org/r/908829

Change 908829 merged by jenkins-bot:

[pywikibot/core@master] [tests] Remove obsolete sites from TestGenerateFamilyFiles test

https://gerrit.wikimedia.org/r/908829

Xqt triaged this task as High priority.

Change 908886 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [tests] Fix obsolete type in TestGenerateFamilyFile

https://gerrit.wikimedia.org/r/908886

Change 908886 merged by jenkins-bot:

[pywikibot/core@master] [tests] Fix obsolete type in TestGenerateFamilyFile

https://gerrit.wikimedia.org/r/908886

Still fails for wikidata

Change 908950 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] Revert "[tests] Fix obsolete type in TestGenerateFamilyFile"

https://gerrit.wikimedia.org/r/908950

Change 908950 merged by Xqt:

[pywikibot/core@master] Revert "[tests] Fix obsolete type in TestGenerateFamilyFile"

https://gerrit.wikimedia.org/r/908950

Change 908966 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [bugfix] Remove sites from FamilyFileGenerator.langs on error

https://gerrit.wikimedia.org/r/908966

Change 908966 merged by jenkins-bot:

[pywikibot/core@master] [bugfix] Remove sites from FamilyFileGenerator.langs on error

https://gerrit.wikimedia.org/r/908966