Page MenuHomePhabricator

Rename Hook interfaces that don't follow naming convention
Closed, ResolvedPublicBUG REPORT

Description

From T334689: Ensure all Hook interfaces contain 'Hook' suffix in their names, three extant hooks from CheckUser are exempted from adhering to the naming convention. These should be fixed, so the exception can be removed.

  • CheckUserInsertChangesRow --> CheckUserInsertChangesRowHook
  • CheckUserInsertLogEventRow --> CheckUserInsertLogEventRowHook
  • CheckUserInsertPrivateEventRow --> CheckUserInsertPrivateEventRowHook

Event Timeline

Change 908988 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CheckUser@master] Add Hook suffix to CheckUserInsert*Hook classes

https://gerrit.wikimedia.org/r/908988

I think another patch will be needed to remove the exception to the core test now that these are renamed.

Change 908988 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add Hook suffix to CheckUserInsert*Hook classes

https://gerrit.wikimedia.org/r/908988

Umherirrender claimed this task.
Umherirrender removed a project: Patch-For-Review.