Page MenuHomePhabricator

Android app doesn't show a spinner or progress bar on most page loads
Closed, ResolvedPublic

Description

There seems to be a modal spinner shown on the initial 'main page' load and when submitting searches, but no spinner at all on page-to-page navigation.

Modal spinners should be avoided if possible; better to show something inline that leaves the UI active and has a way to cancel it.


Version: 1.0.0 (Android)
Severity: normal

Details

Reference
bz31483

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 21 2014, 11:54 PM
bzimport set Reference to bz31483.
brion created this task.Oct 7 2011, 2:48 AM
brion added a comment.Oct 10 2011, 5:57 PM

Need to trap navigation events within the iframe.

yohei.shimomae wrote:

https://github.com/nitobi/Wikipedia/tree/2774232d55c2ade7d80e04ae268ede3f1e95c1e2

Added the UI component for this. Use showSpinner() / hideSpinner() to bring it up.

brion added a comment.Oct 24 2011, 8:22 PM

This looks like a plain animated GIF, which doesn't work on all Android builds: http://code.google.com/p/android/issues/detail?id=3422

Will this reliably work or do we need to do a sprite-style image that animates with a timeout or something?

  • Bug 31952 has been marked as a duplicate of this bug. ***

herman.wong wrote:

added spinner animation

https://github.com/nitobi/Wikipedia/commit/8c53605c20fcd65694c5612b3b69704cee9d29c3

currently it only activates on initial load of the app, search, navigating to search results / bookmarks / history items.

herman.wong wrote:

Initially thought we could use this Android API to capture link clicks in the iframe:

http://developer.android.com/reference/android/webkit/WebViewClient.html#onPageStarted%28android.webkit.WebView,%20java.lang.String,%20android.graphics.Bitmap%29

but it looks like it only works for the main frame and not the iframe.

herman.wong wrote:

seems to work for me.

tested on Android 2.3.6 Nexus S.

brion added a comment.Oct 30 2011, 9:32 PM

On my Nexus 1 w/ Android 2.3.6 I see a spinner when submitting a query from search results, but not during page loads in regular navigation (the subject of this bug).

Reopening.

brion added a comment.Oct 31 2011, 1:57 AM

Ok, can confirm it *is* showing the spinner on regular navigation as of my current working state: https://github.com/nitobi/Wikipedia/commit/8c9753968321723e9074cbfbc2d99115c6016d18

Must have been one of those "Eclipse doesn't see your new files" things. ;)

It exists, but doesn't actually seem to spin - is just 'stuck' in one position during the entire duration of the load.

brion added a comment.Dec 16 2011, 6:48 PM

I've broken out the 'doesn't spin on all devices due to limited animated GIF support' issue to bug 33198; reclosing this one.