Page MenuHomePhabricator

Restore user input widget on Special:Block
Closed, ResolvedPublic

Description

The user input widget on Special:Block (used for the form's target field) was replaced with a users multiselect in T324602.

The reasoning behind this was:

  • Special:Block updates according to the value of the target field
  • The user input widget does not differentiate between accepted input vs in-progress, whereas the multiselect does

There were problems with this however:

A few problems were reported and discussed, e.g. on T332994: Allow target field to be editable on Special:Block if pre-filled with an IP address. In particular, T332994#8780051 makes the widget very troublesome to use, without fixing T334711.

The quickest way to solve this is to restore the user input widget.

Note: The temporary account handling added to CheckUser in T324602 also needs updating.

Event Timeline

Change 904704 had a related patch set uploaded (by Tchanders; author: Func):

[mediawiki/core@master] Revert "Update specialblock target text to use usersmultiselect."

https://gerrit.wikimedia.org/r/904704

Change 909305 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] Re-work SpecialBlock.js for UserInputWidget

https://gerrit.wikimedia.org/r/909305

Change 904704 merged by jenkins-bot:

[mediawiki/core@master] Revert "Update specialblock target text to use usersmultiselect."

https://gerrit.wikimedia.org/r/904704

Change 909305 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Re-work SpecialBlock.js for UserInputWidget

https://gerrit.wikimedia.org/r/909305

Moving this to Done. There's some follow-up work in T334713 and T335253 which can be tested together with this.