profile::wmcs::services::toolsdb_primary and profile::wmcs::services::toolsdb_secondary are almost identical and should be merged into a single file.
In the same folder there is also profile::wmcs::services::toolsdb_replica_cnf that has a somewhat confusing name and could be renamed.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| [toolsdb] Remove unused primary/secondary roles | operations/puppet | production | +0 -19 | |
| P:wmcs: unify toolsdb profiles | operations/puppet | production | +21 -97 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | dcaro | T344411 [toolsdb] ToolsDB replication is broken on tools-db-2 (errno 1032) - 2023-08-17 | |||
| Declined | Superyetkin | T344420 [toolsdb] Copy s51698__yetkin.wanted_items on the replica from the primary | |||
| Resolved | fnegri | T335593 ToolsDB: simplify volume chain | |||
| Resolved | fnegri | T344717 [toolsdb] test creating a new replica host | |||
| Resolved | fnegri | T334929 [toolsdb] merge primary and secondary puppet profiles |
@taavi submitted https://gerrit.wikimedia.org/r/c/operations/puppet/+/789611 quite a while ago for the first part of this.
Change 789611 had a related patch set uploaded (by FNegri; author: Majavah):
[operations/puppet@production] P:wmcs: unify toolsdb profiles
Change 789611 merged by FNegri:
[operations/puppet@production] P:wmcs: unify toolsdb profiles
Change 956903 had a related patch set uploaded (by FNegri; author: FNegri):
[operations/puppet@production] Remove unused toolsdb roles
Change 956903 merged by FNegri:
[operations/puppet@production] [toolsdb] Remove unused primary/secondary roles