API Underpinnings for watchlist
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• RWambua-WMF
	Apr 18 2023, 5:34 PM

Description

Background
The iOS team is bringing the watchlist feature to the app. This will enable users to monitor and track article changes on their selected articles. The engineers need to work on the API underpinnings as the designers work with the designs.

Task

Create all the non-UI mechanics needed to fetch and display Watchlists.
Technical consideration: How many calls should the API make?

Requirements
The functions that are required should include (but not limited to):

Retrieving the current user's watchlist, with continuation.
Adding an article to the current user's watchlist.
Removing an article from the current user's watchlist.
Should have items from all the language wikis that the user has selected on the app.

References
Mediawiki - API Details

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T334212 [Sub-Epic] Watchlist for iOS
		Resolved		None	T334975 API Underpinnings for watchlist

Event Timeline

• RWambua-WMF reassigned this task from • RWambua-WMF to • Dmantena.Apr 18 2023, 5:34 PM

• RWambua-WMF created this task.

• RWambua-WMF removed subscribers: Aklapper, scblr.

JTannerWMF removed a project: Epic.Apr 25 2023, 9:04 PM

JTannerWMF moved this task from Tasks from Product Backlog to Needs Acceptance Criteria on the iOS Release FY2023-24 (Archive) board.Apr 26 2023, 9:40 PM

• RWambua-WMF triaged this task as Medium priority.Apr 28 2023, 2:09 PM

• RWambua-WMF updated the task description. (Show Details)

• RWambua-WMF moved this task from Needs Acceptance Criteria to Ready for Development on the iOS Release FY2023-24 (Archive) board.

LGoto moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.May 2 2023, 6:22 PM

• RWambua-WMF updated the task description. (Show Details)May 23 2023, 1:40 PM

@RWambua-WMF please check in with @Dmantena to ensure he understands this to mean the API provides 500 edits in a call and when Android implemented it had to test it to make sure it wasn't trying to do a continuous pull to show the entire list

Technical consideration: How many calls should the API make?

Tsevener claimed this task.May 30 2023, 8:06 PM

Tsevener moved this task from Ready for Development to Doing on the iOS Release FY2023-24 (Archive) board.

Tsevener added a subscriber: • Dmantena.

API call PRs (Part 1)

Data: https://github.com/wikimedia/wikipedia-ios-data/pull/2
Components: https://github.com/wikimedia/wikipedia-ios-components/pull/11
Client app: https://github.com/wikimedia/wikipedia-ios/pull/4538

Still need to implement Undo and Rollback calls in followup PRs.

Tsevener moved this task from Doing to Needs Code Review on the iOS Release FY2023-24 (Archive) board.Jun 2 2023, 11:00 PM

Tsevener moved this task from Needs Code Review to Doing on the iOS Release FY2023-24 (Archive) board.Jun 28 2023, 4:35 PM

Note: Updated above PRs with Undo and Rollback calls.

Tsevener moved this task from Doing to Needs Code Review on the iOS Release FY2023-24 (Archive) board.Jun 28 2023, 10:05 PM

Merged - this will be tested with the UI tickets.

Tsevener closed this task as Resolved.Jul 8 2023, 1:03 AM

@Tsevener Forgive me if I'm missing something, but a watchlist data element we're missing in WKWatchlist/WKWatchlistService is the per revision byte size.

• Dmantena reopened this task as Open.Aug 4 2023, 4:51 PM

Tsevener moved this task from Ready for Development to Doing on the iOS Release FY2023-24 (Archive) board.Aug 4 2023, 6:52 PM

@Dmantena thanks for catching that! I put a fix in here - https://github.com/wikimedia/wikipedia-ios-data/pull/4.