Page MenuHomePhabricator
Create Task
Maniphest T335148

TypeError: trigger.attr is not a function
Closed, ResolvedPublicBUG REPORT
Actions

Description

In production logs. 331 errors in the last hour. New error in 1.41.0-wmf.5 . Impacts logged in users on certain browsers.
Also appears as InvalidCharacterError: DOMTokenList.add: The token can not contain whitespace.

at https://en.wikipedia.org/w/load.php?lang=en&modules=ext.echo.api%7Cext.eventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.growthExperiments.SuggestedEditSession%7Cext.uls.interface%7Cjquery%7Cjquery.makeCollapsible%7Cmediawiki.base%2Cexperiments%2Cutil%7Cmediawiki.page.watch.ajax%7Coojs-ui.styles.icons-interactions%7Cskins.vector.icons.js%7Cskins.vector.js&skin=vector-2022&version=1usc1:355:510
at Object.fire  https://en.wikipedia.org/w/load.php?lang=en&modules=ext.echo.api%7Cext.eventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.growthExperiments.SuggestedEditSession%7Cext.uls.interface%7Cjquery%7Cjquery.makeCollapsible%7Cmediawiki.base%2Cexperiments%2Cutil%7Cmediawiki.page.watch.ajax%7Coojs-ui.styles.icons-interactions%7Cskins.vector.icons.js%7Cskins.vector.js&skin=vector-2022&version=1usc1:287:808
at ULS.onVisible  https://en.wikipedia.org/w/load.php?lang=en&modules=ext.echo.api%7Cext.eventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.growthExperiments.SuggestedEditSession%7Cext.uls.interface%7Cjquery%7Cjquery.makeCollapsible%7Cmediawiki.base%2Cexperiments%2Cutil%7Cmediawiki.page.watch.ajax%7Coojs-ui.styles.icons-interactions%7Cskins.vector.icons.js%7Cskins.vector.js&skin=vector-2022&version=1usc1:125:878
at ULS.visible  <anonymous>:20:691
at ULS.show  <anonymous>:21:450
at ULS.click  <anonymous>:24:50
at HTMLButtonElement.dispatch  https://en.wikipedia.org/w/load.php?lang=en&modules=ext.echo.api%7Cext.eventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.growthExperiments.SuggestedEditSession%7Cext.uls.interface%7Cjquery%7Cjquery.makeCollapsible%7Cmediawiki.base%2Cexperiments%2Cutil%7Cmediawiki.page.watch.ajax%7Coojs-ui.styles.icons-interactions%7Cskins.vector.icons.js%7Cskins.vector.js&skin=vector-2022&version=1usc1:201:260
at elemData.handle  https://en.wikipedia.org/w/load.php?lang=en&modules=ext.echo.api%7Cext.eventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.growthExperiments.SuggestedEditSession%7Cext.uls.interface%7Cjquery%7Cjquery.makeCollapsible%7Cmediawiki.base%2Cexperiments%2Cutil%7Cmediawiki.page.watch.ajax%7Coojs-ui.styles.icons-interactions%7Cskins.vector.icons.js%7Cskins.vector.js&skin=vector-2022&version=1usc1:197:877
at Object.trigger  https://en.wikipedia.org/w/load.php?lang=en&modules=ext.echo.api%7Cext.eventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.growthExperiments.SuggestedEditSession%7Cext.uls.interface%7Cjquery%7Cjquery.makeCollapsible%7Cmediawiki.base%2Cexperiments%2Cutil%7Cmediawiki.page.watch.ajax%7Coojs-ui.styles.icons-interactions%7Cskins.vector.icons.js%7Cskins.vector.js&skin=vector-2022&version=1usc1:247:983
at HTMLButtonElement.<anonymous>  https://en.wikipedia.org/w/load.php?lang=en&modules=ext.echo.api%7Cext.eventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.growthExperiments.SuggestedEditSession%7Cext.uls.interface%7Cjquery%7Cjquery.makeCollapsible%7Cmediawiki.base%2Cexperiments%2Cutil%7Cmediawiki.page.watch.ajax%7Coojs-ui.styles.icons-interactions%7Cskins.vector.icons.js%7Cskins.vector.js&skin=vector-2022&version=1usc1:248:961

QA steps

  1. Login and visit https://en.wikipedia.org/wiki/Barack_Obama in Chrome
  2. Open the devtools console
  3. Click the ULS button
  4. Verify that ULS opens and that there is not an error in the console
  5. While the ULS dialog is open, scroll down the page.
  6. Verify that the sticky header appears

QA Results - Prod

ACStatusDetails
1✅T335148#8799694
2✅T335148#8799694

Details

SubjectRepoBranchLines +/-
Fix TypeError: trigger.attr is not a functionmediawiki/skins/Vectorwmf/1.41.0-wmf.5+1 -1
Fix TypeError: trigger.attr is not a functionmediawiki/skins/Vectormaster+1 -1
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Apr 20 2023, 3:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2023, 3:56 PM
thcipriani moved this task from Untriaged to Apr 2023 on the Wikimedia-production-error board.Apr 20 2023, 3:56 PM
Jdlrobson updated the task description. (Show Details)Apr 20 2023, 4:00 PM
Nikerabbit subscribed.Apr 20 2023, 4:09 PM

ULS hasn't had any recent changes (that I can see) that could have triggered this: https://github.com/wikimedia/mediawiki-extensions-UniversalLanguageSelector/compare/wmf/1.41.0-wmf.4...wmf/1.41.0-wmf.5

onVisible is a callback function.

gerritbot added a comment.Apr 20 2023, 7:08 PM

Change 910574 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/Vector@master] Fix TypeError: trigger.attr is not a function

https://gerrit.wikimedia.org/r/910574

gerritbot added a project: Patch-For-Review.Apr 20 2023, 7:08 PM
Umherirrender added a project: JavaScript.Apr 20 2023, 7:23 PM
gerritbot added a comment.Apr 20 2023, 7:43 PM

Change 910574 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Fix TypeError: trigger.attr is not a function

https://gerrit.wikimedia.org/r/910574

gerritbot added a comment.Apr 20 2023, 7:49 PM

Change 910499 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/skins/Vector@wmf/1.41.0-wmf.5] Fix TypeError: trigger.attr is not a function

https://gerrit.wikimedia.org/r/910499

gerritbot added a comment.Apr 20 2023, 8:21 PM

Change 910499 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.41.0-wmf.5] Fix TypeError: trigger.attr is not a function

https://gerrit.wikimedia.org/r/910499

Stashbot added a comment.Apr 20 2023, 8:21 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-20T20:21:17Z] <thcipriani@deploy2002> Started scap: Backport for [[gerrit:910499|Fix TypeError: trigger.attr is not a function (T335148)]]

Stashbot added a comment.Apr 20 2023, 8:22 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-20T20:22:41Z] <thcipriani@deploy2002> nray and thcipriani: Backport for [[gerrit:910499|Fix TypeError: trigger.attr is not a function (T335148)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet

Maintenance_bot removed a project: Patch-For-Review.Apr 20 2023, 8:30 PM
Stashbot added a comment.Apr 20 2023, 8:31 PM

Mentioned in SAL (#wikimedia-operations) [2023-04-20T20:31:10Z] <thcipriani@deploy2002> Finished scap: Backport for [[gerrit:910499|Fix TypeError: trigger.attr is not a function (T335148)]] (duration: 09m 53s)

Jdlrobson triaged this task as High priority.Apr 20 2023, 9:46 PM
Jdlrobson added a project: Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 1).
Jdlrobson moved this task from Incoming to QA on the Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 1) board.
• nray moved this task from QA to QA in Production on the Web-Team-Backlog ( Web Team FY2022-23 Q4 Sprint 1) board.Apr 20 2023, 10:22 PM
• nray assigned this task to Edtadros.Apr 20 2023, 10:24 PM
• nray updated the task description. (Show Details)
• nray subscribed.
Edtadros added a comment.Apr 23 2023, 2:27 AM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Login and visit https://en.wikipedia.org/wiki/Barack_Obama in Chrome
Open the devtools console
Click the ULS button
✅ AC1: Verify that ULS opens and that there is not an error in the console
While the ULS dialog is open, scroll down the page.
✅ AC2: Verify that the sticky header appears

Screen Recording 2023-04-22 at 7.26.04 PM.mov.gif (890×1 px, 1 MB)

Edtadros updated the task description. (Show Details)Apr 23 2023, 2:28 AM
Jdlrobson closed this task as Resolved.Apr 24 2023, 3:52 PM

Thanks Edward!

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.5; 2023-04-17).May 15 2023, 6:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits