Page MenuHomePhabricator
Create Task
Maniphest T335155

[Follow-up] Zebra update design review & adjustments
Closed, ResolvedPublic5 Estimated Story PointsBUG REPORT
Actions

Description

This tasks captures refinements to the initial Zebra implementation in T332600.

This includes the following:

  • Finalize content-box padding & spacing
  • Adjust bontent-box padding & spacing for mobile
  • Refine border colors and menu spacing
  • Refine box-shadows for menus
  • Reduce size of header ( & sticky header )
  • Make sidebar columns symmetrical

Details

Other Assignee
bwang
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
[Zebra] Dropdown heading stylesmediawiki/skins/Vectormaster+27 -19
[Zebra] Unify ToC & menu scroll behaviourmediawiki/skins/Vectormaster+51 -92
[Zebra] Add TableOfContents.less to Zebra modulemediawiki/skins/Vectormaster+172 -17
[Zebra] Adjust content paddingmediawiki/skins/Vectormaster+45 -15
[Zebra] Make sidebar columns equal widthmediawiki/skins/Vectormaster+45 -43
Consolidate sticky pinned element styles under .vector-sticky-pinned-container classmediawiki/skins/Vectormaster+47 -65
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdrewniak created this task.Apr 20 2023, 4:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2023, 4:56 PM
Jdrewniak edited projects, added Vector 2022; removed Web-Team-Backlog-Archived (Web Team FY2022-23 Q4 Sprint 2).Apr 20 2023, 5:03 PM
ovasileva triaged this task as High priority.Apr 20 2023, 5:04 PM
Jdlrobson added a project: Web-Team-Backlog-Archived (Web Team FY2022-23 Q4 Sprint 2).Apr 20 2023, 5:05 PM
ovasileva set the point value for this task to 5.Apr 20 2023, 5:11 PM
Jdrewniak mentioned this in T332600: Prepare content columns for Zebra#9 design update.Apr 24 2023, 3:14 PM
ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog-Archived (Web Team FY2022-23 Q4 Sprint 2) board.Apr 24 2023, 4:13 PM
Jdrewniak claimed this task.Apr 24 2023, 7:07 PM
Jdrewniak moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (Web Team FY2022-23 Q4 Sprint 2) board.
Jdrewniak updated Other Assignee, added: bwang.
gerritbot added a comment.Apr 24 2023, 7:08 PM

Change 910787 had a related patch set uploaded (by Jdrewniak; author: Bernard Wang):

[mediawiki/skins/Vector@master] Consolidate sticky pinned element styles under .vector-sticky-pinned-container class

https://gerrit.wikimedia.org/r/910787

gerritbot added a project: Patch-For-Review.Apr 24 2023, 7:08 PM
gerritbot added a comment.Apr 24 2023, 7:38 PM

Change 910787 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Consolidate sticky pinned element styles under .vector-sticky-pinned-container class

https://gerrit.wikimedia.org/r/910787

Maintenance_bot removed a project: Patch-For-Review.Apr 24 2023, 8:12 PM
gerritbot added a comment.Apr 25 2023, 4:50 AM

Change 911435 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] [Zebra] Make sidebar columns equal width

https://gerrit.wikimedia.org/r/911435

gerritbot added a project: Patch-For-Review.Apr 25 2023, 4:50 AM
gerritbot added a comment.Apr 25 2023, 3:05 PM

Change 911882 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] [Zebra] Introduce Codex variables & adjust spacing

https://gerrit.wikimedia.org/r/911882

PatchDemoBot added a comment.Apr 27 2023, 4:32 PM

Test wiki created on Patch demo by JDrewniak (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/5d573e8d36/w

hold_your_horses subscribed.Apr 27 2023, 6:20 PM
gerritbot added a comment.Apr 28 2023, 10:08 PM

Change 911435 merged by jenkins-bot:

[mediawiki/skins/Vector@master] [Zebra] Make sidebar columns equal width

https://gerrit.wikimedia.org/r/911435

Jdlrobson added a subtask: T307256: ToC is not shown during Preview when using the standard WikiEditor.May 1 2023, 5:26 PM
Jdlrobson added a subtask: T335625: siteSub went missing due to zebra transition.
Jdlrobson edited subtasks, added: T335633: table of contents icon in wrong position on articles with long titles; removed: T307256: ToC is not shown during Preview when using the standard WikiEditor.May 1 2023, 5:29 PM
gerritbot added a comment.May 2 2023, 7:27 PM

Change 911882 merged by jenkins-bot:

[mediawiki/skins/Vector@master] [Zebra] Adjust content padding

https://gerrit.wikimedia.org/r/911882

Maintenance_bot removed a project: Patch-For-Review.May 2 2023, 7:29 PM
gerritbot added a comment.May 3 2023, 4:14 PM

Change 914864 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] [Zebra] Add TableOfContents.less to Zebra module

https://gerrit.wikimedia.org/r/914864

gerritbot added a project: Patch-For-Review.May 3 2023, 4:14 PM

Change 914865 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] [Zebra] Unify ToC & menu scroll behaviour

https://gerrit.wikimedia.org/r/914865

PatchDemoBot added a comment.May 3 2023, 7:43 PM

Test wiki created on Patch demo by BWang (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/054564cf39/w

gerritbot added a comment.May 3 2023, 11:28 PM

Change 914864 merged by jenkins-bot:

[mediawiki/skins/Vector@master] [Zebra] Add TableOfContents.less to Zebra module

https://gerrit.wikimedia.org/r/914864

ovasileva closed subtask T335625: siteSub went missing due to zebra transition as Resolved.May 4 2023, 4:37 PM
gerritbot added a comment.May 4 2023, 9:00 PM

Change 914865 merged by jenkins-bot:

[mediawiki/skins/Vector@master] [Zebra] Unify ToC & menu scroll behaviour

https://gerrit.wikimedia.org/r/914865

Maintenance_bot removed a project: Patch-For-Review.May 4 2023, 9:10 PM
gerritbot added a comment.May 4 2023, 10:57 PM

Change 915861 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] [Zebra] Dropdown heading styles

https://gerrit.wikimedia.org/r/915861

gerritbot added a project: Patch-For-Review.May 4 2023, 10:57 PM
gerritbot added a comment.May 5 2023, 5:51 PM

Change 915861 merged by jenkins-bot:

[mediawiki/skins/Vector@master] [Zebra] Dropdown heading styles

https://gerrit.wikimedia.org/r/915861

Maintenance_bot removed a project: Patch-For-Review.May 5 2023, 6:10 PM
bwang moved this task from Doing to QA on the Web-Team-Backlog-Archived (Web Team FY2022-23 Q4 Sprint 2) board.May 8 2023, 3:30 PM
Edtadros closed subtask T335633: table of contents icon in wrong position on articles with long titles as Resolved.May 9 2023, 10:55 PM
Jdrewniak moved this task from QA to Ready for Signoff on the Web-Team-Backlog-Archived (Web Team FY2022-23 Q4 Sprint 2) board.May 11 2023, 6:16 PM

Given we've done testing with Zebra via T335907, I think this can skip QA and go into signoff.

Jdrewniak removed Jdrewniak as the assignee of this task.May 11 2023, 6:17 PM
Jdlrobson assigned this task to ovasileva.May 11 2023, 10:11 PM
ovasileva closed this task as Resolved.May 11 2023, 10:34 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 15 2023, 8:01 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.10; 2023-05-23); removed MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 16 2023, 5:02 AM
PatchDemoBot added a comment.Jul 7 2023, 6:50 PM

Test wiki on Patch demo by BWang (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/054564cf39/w/

PatchDemoBot added a comment.Oct 21 2023, 1:33 PM

Test wiki on Patch demo by JDrewniak (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/5d573e8d36/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits