Page MenuHomePhabricator

Log when a user enables or disables their access to view temporary account IPs
Closed, ResolvedPublic

Description

Essential reading

Parent task description: T325658: Log access to IP addresses of temporary accounts

This task

This task is for:

  • Adding the logging infrastructure
  • Logging whenever a user enables or disables their access via their preferences

Event Timeline

Change 910091 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] Add logging infrastructure for logging temporary account IP address access

https://gerrit.wikimedia.org/r/910091

Change 910091 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add logging infrastructure for logging temporary account IP address access

https://gerrit.wikimedia.org/r/910091

@Tchanders When in preferences with the revealing IP addresses for temporary accounts are toggled off, Show IP does not show up to reveal the IP addresses. Though in Special: Checkuser and Special: Investigate, you are able to view the IP addresses for temporary accounts as seen in the screenshots below. Before I move this to Done, this is as designed, right?

OS: macOS 13.3
Browsers: Chrome 112, Firefox 112, Safari 16.4
Skins: Vector 2022, 2010, Minerva, Monobook, Timeless
Environment: Local

Pages Tested:
Special: RecentChanges
Special: Watchlist
Special: Checkuser
Special: Investigate
Revision history
Diff
Page Information

Toggle on- Show IP

T335365_IPMasking_EnableDisable_Preferences_OnGood.png (805ร—1 px, 333 KB)

Toggle Off

T335365_IPMasking_EnableDisable_Preferences.png (935ร—1 px, 133 KB)

CheckUser

T335365_IPMasking_EnableDisable_Preferences_CheckUser.png (1ร—1 px, 276 KB)

Investigate

T335365_IPMasking_EnableDisable_Preferences_Investigate.png (1ร—1 px, 295 KB)

@GMikesell-WMF - yes this is fine!

If it helps, here's an explanation: essentially once you're using CheckUser, you're (a) a very trusted user who can see IP addresses even of logged-in users, and (b) you're doing a very sensitive investigation for a very good reason which is logged an oversighted. You already have to take a series of very deliberate steps to see the IP addresses listed on Special:CheckUser or Special:Investigate, so there's no preference gating access to it.

@Tchanders Great, I'll move this to Done. Thanks for the explanation, very helpful!