Page MenuHomePhabricator
Create Task
Maniphest T335389

[QA task] Console errors and View history issues
Closed, ResolvedPublic
Actions

Description

(1) The following Console error displayed upon loading the following page https://wikifunctions.beta.wmflabs.org:/wiki/Z10663 produces

Uncaught (in promise)  RangeError: Maximum call stack size exceeded
at Object.get 
 at Object.newGenericObject
 at Object.newObjectByType 
 at Object.newGenericObject

(2) (probably an extreme edge case) View history https://wikifunctions.beta.wmflabs.org/w/index.php?title=Z10112&action=history will display "Revision history of "No label defined in this language or accepted fallbacks" (Z10112)"
instead of displaying Revision history of "Untitled" (Z10112)"

Screen Shot 2023-04-25 at 5.15.05 PM.png (2,110×310 px, 93 KB)

Screen Shot 2023-04-25 at 5.14.54 PM.png (916×190 px, 39 KB)

At some point, there was a Console error:

Error: Unable to parse title
 at new Title

Filed as T335713 (3) Undo from View history doesn't work? Rollback works as expected.

Related Objects

Event Timeline

Etonkovidova created this task.Apr 26 2023, 12:47 AM
Restricted Application added a subscriber: • Aklapper. · View Herald TranscriptApr 26 2023, 12:47 AM
Maintenance_bot added a project: Abstract Wikipedia team.Apr 26 2023, 1:30 AM
Jdforrester-WMF added a comment.Apr 26 2023, 7:45 PM

The first bug is I think because the type is Z10 is no longer valid and breaks things. I've deleted Z10 and now it's working as expected (it already had no implementations or testers).

The second bug is semi-intentional (this was the spec for what to display in this circumstance; we changed it for other things but the new spec was only about the function/object viewer/editor modes, not the history page). Let's pretend it's fine and ignore that part of it. :-) I couldn't replicate the JS console error; do you know how you triggered it?

For the third one, I think this is just "When the editor is triggered via 'undo', enable the 'publish' button immediately even if no changes have been made", and if we're OK with the rest of these items I think we should re-purpose this task to just that?

Jdforrester-WMF moved this task from To Triage to Phase θ – Throttling on the Abstract Wikipedia team board.May 1 2023, 3:43 PM
Jdforrester-WMF edited projects, added: Abstract Wikipedia team (Phase θ – Throttling); removed: Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to Ready to do on the Abstract Wikipedia team (Phase θ – Throttling) board.
Etonkovidova mentioned this in T335713: View history Undo action silently fails.May 1 2023, 9:42 PM
Etonkovidova closed this task as Resolved.May 1 2023, 9:54 PM
Etonkovidova claimed this task.
Etonkovidova updated the task description. (Show Details)
In T335389#8808902, @Jdforrester-WMF wrote:

The first bug is I think because the type is Z10 is no longer valid and breaks things. I've deleted Z10 and now it's working as expected (it already had no implementations or testers).

The second bug is semi-intentional (this was the spec for what to display in this circumstance; we changed it for other things but the new spec was only about the function/object viewer/editor modes, not the history page). Let's pretend it's fine and ignore that part of it. :-) I couldn't replicate the JS console error; do you know how you triggered it?

For the third one, I think this is just "When the editor is triggered via 'undo', enable the 'publish' button immediately even if no changes have been made", and if we're OK with the rest of these items I think we should re-purpose this task to just that?

Thank you, @Jdforrester-WMF - closing this QA task as Resolved and #3 filed as T335713.

Etonkovidova updated the task description. (Show Details)May 1 2023, 9:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits