Page MenuHomePhabricator

Hiding nicknames on the MentorDashboard
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
In languages with long words, nicknames are hidden.

What should have happened instead?:
You need to hide the button, not nicknames.

Other information (browser name/version, screenshots, etc.):

image.png (690×622 px, 62 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Thanks @Iniquity for filing the task! Do you have any more details on the screen width and zoom percentage? Just to make sure that I'm not missing any important information about the issue.
I could reproduce the issue only with the screen width < 1120px and the normal zoom (or with <1115 width and 110% zoom).

Thanks @Inquity for filing the task! Do you have any more details on the screen width and zoom percentage? Just to make sure that I'm not missing any important information about the issue.
I could reproduce the issue only with the screen width < 1120px and the normal zoom (or with <1115 width and 110% zoom).

Oh sorry. Latest Google Chrome, Win10, 1920x1080, Vector-2022

Thanks @Inquity for filing the task! Do you have any more details on the screen width and zoom percentage? Just to make sure that I'm not missing any important information about the issue.
I could reproduce the issue only with the screen width < 1120px and the normal zoom (or with <1115 width and 110% zoom).

Oh sorry. Latest Google Chrome, Win10, 1920x1080, Vector-2022

Thank you, @Inquity!
@Urbanecm_WMF - can you double-check on one of the production MentorDashboards for the presence of the reported issue?

Maybe using an icon instead of a word could help with the language discrepancies, cdxIconUserTalk from Codex icons seems reasonable. I wonder if if we should think of some contextual interface for each table row that helps scaling new mentee actions (star, talk ... ), similar to the Google calendar three vertical dots options for a given calendar:

Screenshot 2023-04-28 at 12.52.31.png (208×594 px, 28 KB)

Hi @Iniquity,

Thanks for filling the task, and for caring about Growth features in general! I tested this, and it seems that this issue is only present with Vector 2022 with the sidebars expanded. Here are screenshots from test.wikipedia Mentor dashboard:

Sidebars minimized

image.png (894×1 px, 172 KB)

Sidebars shown

image.png (887×1 px, 224 KB)

If you want, you can give the module a bit more space by minimizing the two sidebars (when that's done, the usernames seem to appear nearly complete). That said, I completely understand this is not an user friendly solution at all (especially if you like working with the sidebars opened) -- I'm mentioning that as an internim solution you might want to use.

There are a couple of things that can be done to fix this problem:

  1. As you mentioned in the description, hide the (talk) link before hiding parts of the username
  2. As @Sgs noted above, use an icon instead of a link
  3. As @Tgr noted in an internal team discussion about this task, make the numeric columns smaller when the sidebars are in the opened state.
  4. Hide the Vector 2022 sidebars by default, but only when visiting the Mentor dashboard.
  5. Move the (talk) link to its own row, to secure more space for the username.

I think that hiding the talk link first is not a good idea, as that'd be functionaly equivalent to just reverting T322750: On the mentor dashboard, add access the mentee's talk page , where the (talk) links were added. If we want to do something about the (talk) link itself, I'd go with the 5th solution (moving the link to its own line).

The solution by @Tgr sounds best to me. Here is how it would look like:

image.png (865×694 px, 120 KB)

What do you think about those solutions, @Iniquity?

Change 913163 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] WIP: MenteeOverview: Make username column wider when the module is smaller

https://gerrit.wikimedia.org/r/913163

What do you think about those solutions, @Iniquity?

I actually really don't like it if the date will be split across rows. This looks like a bug. It is necessary to abbreviate the word talk itself, it seems to me that using an icon looks the most reasonable.

Change 913163 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] MenteeOverview: Make username column wider when the module is smaller

https://gerrit.wikimedia.org/r/913163

Checked the fix in betalabs - works as expected:

betalabstestwiki wmf.7 (without the fix
Screen Shot 2023-05-04 at 2.59.06 PM.png (1×2 px, 560 KB)
Screen Shot 2023-05-04 at 2.48.05 PM.png (1×2 px, 498 KB)

pinging @Urbanecm_WMF for the comment https://phabricator.wikimedia.org/T335397#8817158.

Thanks Elena!

What do you think about those solutions, @Iniquity?

I actually really don't like it if the date will be split across rows. This looks like a bug. It is necessary to abbreviate the word talk itself, it seems to me that using an icon looks the most reasonable.

The date will split into two rows, but only if both panels (left and right) are expanded (if either of them is collapsed, the module should have enough space to display normally). We can give the date column more space, but that'd mean the username column will be shrinked (after the fix I prepared, all other columns are shrinked to the greatest possible amount).

I'm not sure about the icon idea. I'm afraid that it: (a) decreases accessibility (which is still somewhat a problem in the header, where only icons are used, so probably not a big issue) (b) needs a lot of horizontal space to be clickable (see the star icon, which spans across both the username and the "active ago" info) (c) using an icon to access talk page is not used elsewhere, as far as I know.

Hi @JFernandez-WMF @KStoller-WMF @Trizek-WMF, do you have any opinions to share about this topic? Thanks!

I agree an icon doesn't seem like a good choice unless it's used elsewhere and already widely recognized.

I also don't like the date being split across two rows, but I don't see an obvious way to improve that without creating other layout issues. My general sense is that it's probably OK since the number of mentors regularly using this feature is fairly low. However if anyone else has an idea for an easy improvement, please feel free to provide it. Thanks!

There is actually another way. We can say in the description of the interface message that it is desirable to shorten the word to 3-5 characters.
https://translatewiki.net/wiki/MediaWiki:Growthexperiments-mentor-dashboard-mentee-overview-talk/qqq
{F36988881}

I think I will not start a separate task. These long lines disappear beyond the cell border.

image.png (166×248 px, 14 KB)

There is actually another way. We can say in the description of the interface message that it is desirable to shorten the word to 3-5 characters.
https://translatewiki.net/wiki/MediaWiki:Growthexperiments-mentor-dashboard-mentee-overview-talk/qqq
{F36988881}

@Trizek-WMF thoughts on this approach? I assume 3-5 characters might be tricky in some languages, but perhaps it would work?

Can't we remove the talk page link, and link the username to Special:Contributions? From there, it is possible to access the talk page, the user pages, etc.

If we keep the talk page link maybe we could take inspiration from user link templates, where several languages use shortcuts for links to user talk pages (t for talk, d for discussions, обс....), etc.

Let's not forget that mentors are often advanced users; shortcuts or icons are acceptable for them. Hence, the idea of asking translators to use a shorten message would also work.

Can't we remove the talk page link, and link the username to Special:Contributions? From there, it is possible to access the talk page, the user pages, etc.

I've to note the Special:Contributions link is available from the fourth column (number of total edits). Agreed, it is not very visible, and it might be missed easily by the community members. Should we replace the userpage/talk link with Special:Contributions in the first column, and link Special:Contributions the second time from the number?

If we keep the talk page link maybe we could take inspiration from user link templates, where several languages use shortcuts for links to user talk pages (t for talk, d for discussions, обс....), etc.

Let's not forget that mentors are often advanced users; shortcuts or icons are acceptable for them. Hence, the idea of asking translators to use a shorten message would also work.

I like the template solution. We can community configure its name and communities can use it to define shorter names. The only issue is that not all communities use Q5930006 for "shorter" links; for example, Czech Wikipedia uses the following:

Martin Urbanec (WMF) (diskuse • příspěvky • počítadlo • články • shrnutí • zablokování • všechny projekty)

which wouldn't fit into the template at all. So, maybe we shouldn't preload this config item from Wikidata?

For the links, I think we should ask mentors directly. Do they use the dashboard, and which improvement they'd like to see on the table of mentees.

Regarding templates, I picked them as an example to shorten words. Iniquity suggests to encourage translators to use a shorter term, which would be easier to implement than going through configuration, don't you think?

For the links, I think we should ask mentors directly. Do they use the dashboard, and which improvement they'd like to see on the table of mentees.

👍

Regarding templates, I picked them as an example to shorten words. Iniquity suggests to encourage translators to use a shorter term, which would be easier to implement than going through configuration, don't you think?

Yes, certainly. We can make this more clear in the qqq, too.

Let's consider this task resolved, but if anyone wants to suggest a further design improvement, please open a new task that we can try to fit in design time on.