Page MenuHomePhabricator

SyntaxError: Failed to execute 'closest' on 'Element': 'a.image:not(.noviewer,.metadata),a.thumbimage:not(.noviewer,.metadata)' is not a valid selector.
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
message
SyntaxError: Failed to execute 'closest' on 'Element': 'a.image:not(.noviewer,.metadata),a.thumbimage:not(.noviewer,.metadata)' is not a valid selector.
trace
at HTMLDivElement.onClickImage  https://it.m.wikipedia.org/w/load.php?lang=it&modules=ext.centralNotice.choiceData%2Cdisplay%2CgeoIP%2CimpressionDiet%2CkvStore%2CstartUp%7Cext.centralauth.ForeignApi%2Ccentralautologin%7Cext.cite.ux-enhancements%7Cext.cx.entrypoints.languagesearcher.init%7Cext.cx.entrypoints.mffrequentlanguages%7Cext.cx.eventlogging.campaigns%7Cext.cx.model%7Cext.dismissableSiteNotice%2CeventLogging%2CnavigationTiming%2Cpopups%2CwikimediaEvents%7Cext.echo.centralauth%7Cext.growthExperiments.SuggestedEditSession%7Cext.relatedArticles.readMore.bootstrap%7Cjquery%2Coojs%2Csite%7Cjquery.client%2Ccookie%7Cmediawiki.ForeignApi%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2Ccookie%2Cexperiments%2CjqueryMsg%2Clanguage%2Crouter%2Cstorage%2Ctemplate%2Cuser%2Cutil%2CvisibleTimeout%7Cmediawiki.ForeignApi.core%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cmediawiki.template.mustache%7Cmediawiki.ui.anchor%7Cmobile.init%2Cstartup%7Cmobile.ooui.icons%7Cmobile.pagelist.styles%7Cmobile.pagesummary.styles%7Cmobile.placeholder.images%7Cmobile.startup.images%7Cmw.cx.SiteMapper%7Cmw.externalguidance.init%7Cskins.minerva.icons.images.scripts.misc%7Cskins.minerva.icons.page.issues.default.color%7Cskins.minerva.icons.page.issues.medium.color%7Cskins.minerva.icons.page.issues.uncolored%7Cskins.minerva.messageBox.styles%7Cskins.minerva.scripts&skin=minerva&version=g8gqv:567:474
Impact

6k errors in last hour.

Notes

I think caused by T241139, https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/908674

Event Timeline

Change 912371 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/extensions/MobileFrontend@master] Fix `a.image:not(.noviewer,.metadata),a.thumbimage:not(.noviewer,.metadata)' is not a valid selector` bug

https://gerrit.wikimedia.org/r/912371

Change 912371 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Fix `a.image:not(.noviewer,.metadata),a.thumbimage:not(.noviewer,.metadata)' is not a valid selector` bug

https://gerrit.wikimedia.org/r/912371

Change 912379 had a related patch set uploaded (by Nray; author: Nray):

[mediawiki/extensions/MobileFrontend@wmf/1.41.0-wmf.6] Fix `a.image:not(.noviewer,.metadata),a.thumbimage:not(.noviewer,.metadata)' is not a valid selector` bug

https://gerrit.wikimedia.org/r/912379

Change 912379 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@wmf/1.41.0-wmf.6] Fix `a.image:not(.noviewer,.metadata),a.thumbimage:not(.noviewer,.metadata)' is not a valid selector` bug

https://gerrit.wikimedia.org/r/912379

Mentioned in SAL (#wikimedia-operations) [2023-04-26T23:25:02Z] <zabe@deploy1002> Started scap: Backport for [[gerrit:912379|Fix a.image:not(.noviewer,.metadata),a.thumbimage:not(.noviewer,.metadata)' is not a valid selector bug (T335451)]]

Mentioned in SAL (#wikimedia-operations) [2023-04-26T23:26:28Z] <zabe@deploy1002> zabe and nray: Backport for [[gerrit:912379|Fix a.image:not(.noviewer,.metadata),a.thumbimage:not(.noviewer,.metadata)' is not a valid selector bug (T335451)]] synced to the testservers: mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-04-26T23:32:09Z] <zabe@deploy1002> Finished scap: Backport for [[gerrit:912379|Fix a.image:not(.noviewer,.metadata),a.thumbimage:not(.noviewer,.metadata)' is not a valid selector bug (T335451)]] (duration: 07m 07s)

Jdlrobson lowered the priority of this task from Unbreak Now! to Medium.
Jdlrobson subscribed.

I'll verify this in production today.