| Etonkovidova | |
| Apr 27 2023, 12:29 AM |
| F36998544: Screen Shot 2023-05-15 at 3.08.19 PM.png | |
| May 15 2023, 10:14 PM |
found when checking T301981
Steps to reproduce:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| ChangeMentor: Do not allow opted-out users to be claimed | mediawiki/extensions/GrowthExperiments | master | +12 -1 |
Seems like we'd want to fix this as it would be confusing to the mentee; moving to current sprint.
@KStoller-WMF @Trizek-WMF @Urbanecm_WMF should we disallow claiming users as mentees if they opted out of mentorship? Or should we allow mentors to override this?
We should not allow mentors to claim mentees who voluntarily opt-out mentorship.
OTOH, we should turn Growth features on for newcomers who claimed while they are in a control group or a similar exclusion group.
Change 914378 had a related patch set uploaded (by Urbanecm; author: Urbanecm):
[mediawiki/extensions/GrowthExperiments@master] ChangeMentor: Do not allow opted-out users to be claimed
Agreed -- uploaded a patch.
OTOH, we should turn Growth features on for newcomers who claimed while they are in a control group or a similar exclusion group.
That should be already happening (when the module is disabled by us, rather than by the user). The only case when we don't enable anything is when the claimed user has no Homepage at all (when we do change the mentor, but do not send any notification).
Change 914378 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] ChangeMentor: Do not allow opted-out users to be claimed
Checked in testwiki wmf.8- the issue is fixed.
