Page MenuHomePhabricator

Galleries in categories don't have newlines before/after page links.
Open, NormalPublic

Description

Screenshot of lack of line break

Something to do with changing galleries from being a block element to weird <ul> inline-block thingy. Basically no linebreak before/after gallery so nav links on same line (noticable when only a few items). See screenshot

For reference, browser: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.16) Gecko/20110302 Iceweasel/3.5.16 (like Firefox/3.5.16) and trunk mediawiki (r99313)


Version: 1.18.x
Severity: normal

Attached:

Details

Reference
bz31550

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 21 2014, 11:47 PM
bzimport added a project: MediaWiki-Categories.
bzimport set Reference to bz31550.
bzimport added a subscriber: Unknown Object (MLST).
Bawolff created this task.Oct 9 2011, 3:38 AM

tagging bugs for Marcus to look at

TheDJ added a comment.Oct 22 2011, 9:28 PM

Seems your browser is buying into the IE hack then....

/* Galleries */
/* These display attributes look nonsensical, but are needed to support IE and FF2 */
/* Don't forget to update commonPrint.css */
li.gallerybox {

		vertical-align: top;
		border: solid 2px white;
		display: -moz-inline-box;
		display: inline-block;

}

ul.gallery, li.gallerybox {

		zoom: 1;
		*display: inline;

}

ul.gallery {

		margin: 2px;
		padding: 2px;
		display: block;

}

My chrome and safari ignore that display:inline; (as they should)....

Firebug is claiming that display style is set to inline-block...

It says the following styles are active o the li.gallerybox (minus a couple things inherited on pretty much all elements)

element.style {
width:155px;
}
ul.gallery, li.gallerybox {
}
li.gallerybox {
border:2px solid white;
display:inline-block;
vertical-align:top;
}
li {
margin-bottom:0.1em;
}

Inherited from ul.gallery
ul {
list-style-image:url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAUAAAANCAMAAABW4lS6AAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAAZQTFRFAFKM////QIUK9QAAAAJ0Uk5T/wDltzBKAAAAGklEQVR42mJgBAEGokgGBjBGBxBxsBqAAAMACHwALd5r8ygAAAAASUVORK5CYII=);
}
ul {
line-height:1.5em;
list-style-type:square;
}

TheDJ added a comment.Oct 23 2011, 8:54 PM

li.gallerybox is not relevant here right ? the ul.gallery is what should matter and which should behave like a block element.

(In reply to comment #4)

li.gallerybox is not relevant here right ? the ul.gallery is what should matter
and which should behave like a block element.

Whoops, yes you're right, ul.gallery is the important one.

Firebug says for the ul.gallery we have
ul.gallery {
display:inline-block;
margin:2px;
padding:2px;
}

Which is coming from mediawiki.legacy.shared. My shared.css looks different from what you pasted above (seems to have been changed in r93581)

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2015, 11:12 PM