Error: Call to a member function getId() on bool
Closed, DeclinedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	thcipriani
	Apr 27 2023, 3:25 PM

Description

Error

service.version: 1.41.0-wmf.5
trace.id: c7ffef4e-6e90-4cc2-82b8-d01374cd752b
Find trace.id in Logstash

labels.normalized_message

[{reqId}] {exception_url}   Error: Call to a member function getId() on bool

error.stack_trace

from /srv/mediawiki/php-1.41.0-wmf.5/extensions/OAuth/src/SessionProvider.php(126)
#0 /srv/mediawiki/php-1.41.0-wmf.5/includes/session/SessionManager.php(537): MediaWiki\Extension\OAuth\SessionProvider->provideSessionInfo(WebRequest)
#1 /srv/mediawiki/php-1.41.0-wmf.5/includes/session/SessionManager.php(244): MediaWiki\Session\SessionManager->getSessionInfoForRequest(WebRequest)
#2 /srv/mediawiki/php-1.41.0-wmf.5/includes/WebRequest.php(840): MediaWiki\Session\SessionManager->getSessionForRequest(WebRequest)
#3 /srv/mediawiki/php-1.41.0-wmf.5/includes/session/SessionManager.php(165): WebRequest->getSession()
#4 /srv/mediawiki/php-1.41.0-wmf.5/includes/Setup.php(478): MediaWiki\Session\SessionManager::getGlobalSession()
#5 /srv/mediawiki/php-1.41.0-wmf.5/includes/WebStart.php(92): require_once(string)
#6 /srv/mediawiki/php-1.41.0-wmf.5/rest.php(29): require(string)
#7 /srv/mediawiki/w/rest.php(3): require(string)
#8 {main}

Notes

One very small spike of these over the past 90 days
all for enwiki
All via GET requests
All very simple title searches, e.g., https://en.wikipedia.org/w/rest.php/v1/search/title?limit=5&q=<single-word-term>

Details

Request URL: https://en.wikipedia.org/w/rest.php/v1/search/title?limit=*&q=*

Related Objects

Mentioned In: T344622: Error: Call to a member function getId() on null (in ThreadItemStore)
T344623: Error: Call to a member function getId() on null (in ApiCoreThank)

Event Timeline

thcipriani created this task.Apr 27 2023, 3:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 27 2023, 3:25 PM

thcipriani moved this task from Untriaged to Apr 2023 on the Wikimedia-production-error board.Apr 27 2023, 3:25 PM

Code is $resourceServer->getUser()->getId() === 0 where $resourceServer is of type ResourceServer and ResourceServer::getUser is documented to return User only (no null or false).

There is possible a false from Utils::getLocalUserFromCentralId when local user is not found or attached, it seems $wgMWOAuthSharedUserIDs = true is set for wmf wikis (CommonsSettings.php sets $wgMWOAuthCentralWiki = 'metawiki' and that makes the other config true).

So there could be some race condition with autocreation of accounts on the local wiki (via CentralAuth?) and use of the oauth functions

Umherirrender removed a subscriber: Umherirrender.Jul 12 2023, 8:18 PM

Krinkle removed a project: Platform Engineering.Aug 17 2023, 3:58 PM

Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptAug 17 2023, 3:58 PM

pmiazga triaged this task as Medium priority.Aug 21 2023, 1:23 PM

larissagaulia moved this task from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.Aug 21 2023, 1:23 PM

pmiazga assigned this task to matmarex.Aug 21 2023, 1:48 PM

There are no occurrences of this error in Logstash in the last 90 days, which is as far back as the logs go: https://logstash.wikimedia.org/goto/06b46a561c07b8734119df1960d0e004. Since we don't have a good idea of the cause or how to reproduce this ("could be some race condition"), I think this is not worth investigating until it reoccurs.

matmarex mentioned this in T344623: Error: Call to a member function getId() on null (in ApiCoreThank).Aug 21 2023, 4:02 PM

matmarex mentioned this in T344622: Error: Call to a member function getId() on null (in ThreadItemStore).Aug 21 2023, 4:05 PM

Error: Call to a member function getId() on boolClosed, DeclinedPublicPRODUCTION ERRORActions