Page MenuHomePhabricator
Create Task
Maniphest T335530

New messages are needed for warnings about logged-out editing for IP masking
Closed, ResolvedPublic
Actions

Assigned To
matmarex
Authored By
matmarex
Apr 27 2023, 7:02 PM
Tags
Referenced Files
F36968301: Screenshot_20230428-213511_Wikipedia Alpha.png
Apr 28 2023, 7:38 PM
F36968281: image.png
Apr 28 2023, 7:23 PM
F36964984: image.png
Apr 28 2023, 1:50 AM
F36964993: image.png
Apr 28 2023, 1:50 AM
F36965300: image.png
Apr 28 2023, 1:50 AM
F36965302: image.png
Apr 28 2023, 1:50 AM
F36964807: image.png
Apr 27 2023, 7:17 PM
F36964797: 617DCDB5-086F-4AA1-9D55-D4D2EA0B6A9A.png
Apr 27 2023, 7:17 PM
View All 13 Files
Subscribers
Aklapper
cmadeo
matmarex
• ppelberg
Tacsipacsi
• Whatamidoing-WMF

Description

Logged-out users see particular warnings about their IP address being exposed when editing. When IP masking is enabled, they need to be changed to inform them about temporary account instead.

Temporary wikis for testing:

In scope for Editing-team:

IP masking disabledIP masking enabledNotes / Task
Core wikitext editor
image.png (661×1 px, 75 KB)
image.png (661×1 px, 83 KB)
Already done in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/778684
Visual editor
image.png (663×1 px, 117 KB)
image.png (663×1 px, 173 KB)
Will use the same message as core after T201613
Mobile editor
image.png (2×1 px, 65 KB)
image.png (2×1 px, 78 KB)
T332433
Discussion tools
image.png (809×1 px, 73 KB)
image.png (795×1 px, 74 KB)
T332432

Out of scope: (I'm intending this as a reference for maintainers of other tools, feel free to add more items)

IP masking disabledIP masking enabledNotes / Task
iOS app
617DCDB5-086F-4AA1-9D55-D4D2EA0B6A9A.png (1×640 px, 85 KB)
???T329913
Android app
Screenshot_20230428-213511_Wikipedia Alpha.png (2×1 px, 483 KB)
???T329913
Convenient Discussions
image.png (563×1 px, 46 KB)
???
Wikidata
image.png (476×1 px, 80 KB)
???
...

Details

SubjectRepoBranchLines +/-
Add a link to doc page in messages about creation of temporary accountsmediawiki/coremaster+16 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Apr 27 2023, 7:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 27 2023, 7:02 PM
matmarex mentioned this in T335532: Expose IP masking (temporary user creation) configuration in the API.Apr 27 2023, 7:03 PM
matmarex edited projects, added Editing-team (Kanban Board); removed Editing-team.
matmarex added a subtask: T335532: Expose IP masking (temporary user creation) configuration in the API.
matmarex updated the task description. (Show Details)Apr 27 2023, 7:17 PM
matmarex updated the task description. (Show Details)Apr 27 2023, 7:50 PM
matmarex moved this task from Incoming to Design Review on the Editing-team (Kanban Board) board.Apr 27 2023, 11:51 PM
matmarex renamed this task from Update warnings for logged-out users across the web editors to Update warnings for logged-out users across the web editors for IP masking.Apr 28 2023, 1:50 AM
matmarex updated the task description. (Show Details)
matmarex removed a subtask: T335532: Expose IP masking (temporary user creation) configuration in the API.Apr 28 2023, 1:55 AM
matmarex renamed this task from Update warnings for logged-out users across the web editors for IP masking to New messages are needed for warnings about logged-out editing for IP masking.Apr 28 2023, 6:24 PM
matmarex added parent tasks: T332432: Update DiscussionTools for IP masking, T332433: Update page editing features in MobileFrontend for IP masking, T332435: Update VisualEditor for IP masking.
matmarex added projects: DiscussionTools, MobileFrontend, VisualEditor.
matmarex moved this task from To Triage to Triaged on the VisualEditor board.
matmarex moved this task from Backlog to Triaged on the DiscussionTools board.
matmarex moved this task from Backlog to Team:Editing on the MobileFrontend board.Apr 28 2023, 6:26 PM
matmarex mentioned this in T332432: Update DiscussionTools for IP masking.
matmarex mentioned this in T332433: Update page editing features in MobileFrontend for IP masking.
matmarex mentioned this in T332435: Update VisualEditor for IP masking.
matmarex updated the task description. (Show Details)Apr 28 2023, 7:23 PM
Tacsipacsi updated the task description. (Show Details)Apr 28 2023, 7:38 PM
Tacsipacsi subscribed.
• Whatamidoing-WMF subscribed.EditedMay 2 2023, 8:34 PM

Should "If you log in or create an account..." say something like "If you log in or create a permanent account..." or "If you log in or create a regular account..." or "If you log in or create a personal account..."? People seeing this message will have a (temporary) account.

Overall, I think these proposed changes are good.

matmarex added a comment.May 2 2023, 10:22 PM

Maybe… I copied that wording from the existing messages.

matmarex moved this task from Design Review to Code Review on the Editing-team (Kanban Board) board.May 4 2023, 6:58 PM
matmarex added a comment.May 5 2023, 5:48 PM

As suggested by @Whatamidoing-WMF in T335590, I'll also add a link to https://www.mediawiki.org/wiki/Help:Temporary_accounts to these messages.

gerritbot added a comment.May 5 2023, 7:57 PM

Change 916593 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] Add a link to doc page in messages about creation of temporary accounts

https://gerrit.wikimedia.org/r/916593

gerritbot added a project: Patch-For-Review.May 5 2023, 7:57 PM
gerritbot added a comment.May 11 2023, 5:20 PM

Change 916593 merged by jenkins-bot:

[mediawiki/core@master] Add a link to doc page in messages about creation of temporary accounts

https://gerrit.wikimedia.org/r/916593

Maintenance_bot removed a project: Patch-For-Review.May 11 2023, 5:30 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 8:01 PM
matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.May 17 2023, 4:10 PM
cmadeo subscribed.May 24 2023, 4:29 PM

Hi! Some updated designs for iOS are available at T337250. Android will be coming soon too.

• ppelberg subscribed.May 31 2023, 5:28 PM
• ppelberg mentioned this in T338171: Revise UI copy for temporary accounts.Jun 5 2023, 5:20 PM
matmarex closed this task as Resolved.Jun 5 2023, 5:34 PM

The work to create separate messages for temporary users is done now. Any updates to the messages will be handled in T338171.

Ryasmeen added a project: Verified.Nov 8 2023, 2:51 AM
Ryasmeen mentioned this in T344468: QA Editing-related IP Masking changes.Nov 9 2023, 9:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL