Page MenuHomePhabricator

Validate `ios_login_action` data post-release
Closed, ResolvedPublic

Event Timeline

LGoto triaged this task as Low priority.May 2 2023, 6:19 PM

@Mazevedo we should look into this, only seeing 4 event rows, 2 are wmf_app_version = 7.3.0.0 and 2 are wmf_app_version = 7.3.0.2213, dates are 2023-05-19 and 2023-05-20.

Data Validation T335550

Fix is in 7.3.1 (Testflight beta).

While we are seeing events mostly as expected the daily event counts seem low (daily average login success events ~31.9). Also the counts for createaccount_start are very low (only 8 in 30 day period) while createaccount_success is 575 - is it possible this event is not being measured properly?

Other notes that may need a second look:
Not seeing category values feed and description (these may be outdated events and not necessary).

(I'm unsure of the current login logic in-app and how frequently users are prompted to login - presumably they can stay logged in indefinitely so the low count may not be a problem.)

Data Validation v2

While we are seeing events mostly as expected the daily event counts seem low (daily average login success events ~31.9). Also the counts for createaccount_start are very low (only 8 in 30 day period) while createaccount_success is 575 - is it possible this event is not being measured properly?

Other notes that may need a second look:
Not seeing category values feed and description (these may be outdated events and not necessary).

(I'm unsure of the current login logic in-app and how frequently users are prompted to login - presumably they can stay logged in indefinitely so the low count may not be a problem.)

Data Validation v2

I'll also check those and let you know if we need a fix

Hi just adding this for tracking, we can use this to validate after you've looked into issues. For the low counts on createaccount_success events we have another way to verify new accounts created daily using the ServerSideAccountCreation schema. Counts there avg ~97 new accounts daily, on our schema it's ~16 so definitely missing events - caveat the counts won't ever match exactly because of users who have opted out of sharing.

New account event compare

Hi @SNowick_WMF

Other notes that may need a second look:
Not seeing category values feed and description (these may be outdated events and not necessary).

We're not sending these categories, they ended up being outdated

While we are seeing events mostly as expected the daily event counts seem low (daily average login success events ~31.9). Also the counts for createaccount_start are very low (only 8 in 30 day period) while >createaccount_success is 575 - is it possible this event is not being measured properly?

I was debugging it in another way, so I went and created a new account to check it - we're calling the events and they're being sent with no server errors. I can try to look into it a little more, but I have little idea of what might be causing theses issues.

@SNowick_WMF hmm, we're logging createaccount_success in the same spot as we did in 7.2.2 (which used the legacy system), it just now routes the event to the MEP endpoint under the hood. Would it be possible to compare the ServerSideAccountCreation against the 7.2.2 numbers? Just wondering if you see the same discrepancies.

Mazevedo moved this task from Doing to Needs Analytics on the iOS Release FY2023-24 (Archive) board.

Hi @SNowick_WMF , moving to needs analytics to check if you found anything related to Toni's comment above:

@SNowick_WMF hmm, we're logging createaccount_success in the same spot as we did in 7.2.2 (which used the legacy system), it just now routes the event to the MEP endpoint under the hood. Would it be possible to compare the ServerSideAccountCreation against the 7.2.2 numbers? Just wondering if you see the same discrepancies.

Back to this task - sorry for the delay. Login_success and createaccount_successcounts still look low to me, some things I noticed:

  • We have login_start events for category = login_to_sync_popover but no login_success events associated with that category so we should check that (Data)
  • We are still not matching daily created account counts that we get from ServerSideAccountCreation. The only category we have for createaccount_start and createaccount_success events is login, just to be sure are there no other prompts to create an account in the app? Maybe we are missing a category? (Data)

Added login_to_sync_popover categories in events, starting in TestFlight build 7.4.6 (2963).

Validating that I am now seeing events in ios_login_action where category = login_to_sync_popover and action = login_success, counts are very small but looks like fix was successful.

Will keep an eye on this and close ticket when I get more data. Engineering can consider this resolved unless otherwise noted.

@Tsevener Hello, I was not exaclty sure how to test this one. I installed 7.4.6 (2963) and tried logging in/out on both English and Test langs. I went to this page and added ios_login_action as the event stream, but so far I have not seen anything. Am I missing a something? Thanks

@ABorbaWMF If you trigger this modal from Settings by logging out, then going to "Article storage and syncing", and toggling on the "Sync saved articles and lists" toggle, the login flow from that modal should trigger events with the "login_to_sync_popover" category. I am not sure how to get it to show up in that event streams tool though, I also don't see anything.

Based on @SNowick_WMF 's last comment about us considering this resolved, I'm going to move this into her column. Thanks!

Keeping this open to re-check after data sharing changes - our biggest issue was seeing very low event counts, should see increase and if not will re-open with engineering.

Based on original schema the most obvious missing events are from feed category which may have been replaced with new code - where on feed are ogin/create account events triggered?

SNowick_WMF closed this task as Resolved.EditedFri, May 17, 8:04 PM

This is resolved. Counts are matching now as we expected to see. Data