Page MenuHomePhabricator

Standardize Minerva user menu overflow
Closed, ResolvedPublicBUG REPORT

Description

Currently it's impossible to extend the user more menu that shows on
https://en.wikipedia.org/wiki/User:Jdlrobson?useskin=minerva

Screenshot 2023-04-28 at 12.32.36 PM.png (225×349 px, 32 KB)

We should generalize this code so that it uses the menus defined in core and that others can add items provided they associate their menu item with an icon.

Expected changes

  • The ordering respects the ordering on desktop (consistency being a goal of this patch) e.g. What links here is now the top link.
  • The menu labels should match the desktop menu label equivalents. e.g. User groups is now "Change user groups"
  • If a menu item declares an icon, it will now appear in the menu (and didn't before). This was kind of the point of the patch - to allow expansion but nothing has done that yet so there should be no additional items.

Details

Related Changes in Gerrit:

Event Timeline

Change 902822 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Standardize user overflow menu

https://gerrit.wikimedia.org/r/902822

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/76400afa8a/w

Change 902822 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Standardize user overflow menu

https://gerrit.wikimedia.org/r/902822

Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/76400afa8a/w/

Jdlrobson claimed this task.
Jdlrobson moved this task from Backlog to Menus 2.0 on the MediaWiki-Core-Skin-Architecture board.

Menus can now be added to in the same way as Vector. The only requirement is they define an icon key (and provide styles)